METK-153: Set python/pybind11 as required packages for pymars2grib#154
Open
METK-153: Set python/pybind11 as required packages for pymars2grib#154
Conversation
Additionally fix function argument order, previously undetected
simondsmart
reviewed
Feb 4, 2026
|
|
||
| py::bytes encode(Mars2Grib& encoder, const std::vector<double>& values, const py::dict& mars, const py::dict& misc) { | ||
| const auto message = encoder.encode(dictToLocalConfig(mars), dictToLocalConfig(misc), values); | ||
| const auto message = encoder.encode(values, dictToLocalConfig(mars), dictToLocalConfig(misc)); |
Contributor
There was a problem hiding this comment.
This is a peculiar change to have in this commit. It changes the use of the API, and has nothing to do with pybind11/defaults/etc.
Member
Author
There was a problem hiding this comment.
We can take it out and put it in a commit before. Would that be better?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #154 +/- ##
========================================
Coverage 54.18% 54.18%
========================================
Files 300 300
Lines 11564 11564
Branches 1025 1025
========================================
Hits 6266 6266
Misses 5298 5298 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets Python3 and Pybind11 as required packages to build the pymars2grib bindings.
Also disables building pymars2grib by default.
Also fixed order of arguments, which we changed at the end of the push last week, and got undetected because this was silently not being build...