Skip to content

Feat/fix select#82

Merged
mathleur merged 7 commits intofeature/rustfrom
feat/fix_select
Mar 26, 2026
Merged

Feat/fix select#82
mathleur merged 7 commits intofeature/rustfrom
feat/fix_select

Conversation

@mathleur
Copy link
Copy Markdown
Member

Description

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@mathleur mathleur changed the base branch from main to feature/rust March 25, 2026 10:10
@mathleur mathleur requested a review from Copilot March 25, 2026 10:10
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts Qube::select behavior to prune empty placeholder branches when a selected dimension/value only appears deeper in the tree, and updates/extends tests to reflect the corrected semantics (including post-union compression behavior).

Changes:

  • Prune newly-created result nodes during selection when recursion yields no matching descendants (avoids empty branches).
  • Add Rust and Python test coverage for selecting deep keys and irregular dimension ordering.
  • Update union test expectations to match append()’s always-compress behavior.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
qubed/src/select.rs Adds pruning of empty result branches during select_recurse and introduces several regression tests around deep-key selection and irregular trees.
qubed/tests/test_union.rs Updates test to assert post-append() compressed structure rather than structural hash equality.
py_qubed/tests/test_select_api.py Adds Python regression tests ensuring deep-key selection prunes non-matching branches; minor formatting cleanups.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread qubed/src/select.rs
Comment thread qubed/src/select.rs Outdated
Comment thread qubed/src/select.rs Outdated
Comment thread qubed/src/select.rs
Comment thread qubed/src/select.rs
mathleur and others added 5 commits March 25, 2026 14:20
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@mathleur mathleur merged commit e0c898c into feature/rust Mar 26, 2026
1 check failed
@mathleur mathleur deleted the feat/fix_select branch March 26, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants