Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts Qube::select behavior to prune empty placeholder branches when a selected dimension/value only appears deeper in the tree, and updates/extends tests to reflect the corrected semantics (including post-union compression behavior).
Changes:
- Prune newly-created result nodes during selection when recursion yields no matching descendants (avoids empty branches).
- Add Rust and Python test coverage for selecting deep keys and irregular dimension ordering.
- Update union test expectations to match
append()’s always-compress behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
qubed/src/select.rs |
Adds pruning of empty result branches during select_recurse and introduces several regression tests around deep-key selection and irregular trees. |
qubed/tests/test_union.rs |
Updates test to assert post-append() compressed structure rather than structural hash equality. |
py_qubed/tests/test_select_api.py |
Adds Python regression tests ensuring deep-key selection prunes non-matching branches; minor formatting cleanups. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contributor Declaration
By opening this pull request, I affirm the following: