Add .js extensions to echarts/zrender deep imports (ESM / echarts 6 compat)#575
Open
alidor4702 wants to merge 1 commit into
Open
Add .js extensions to echarts/zrender deep imports (ESM / echarts 6 compat)#575alidor4702 wants to merge 1 commit into
alidor4702 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Appends
.jsto the extensionlessecharts/lib/...andzrender/lib/...deep imports insrc/.echarts 6 and zrender 6 added strict package
exportsmaps ending in a"./*": "./*"catch-all, which resolve specifiers literally and no longer auto-append.js. As a result, strict-ESM bundlers (esbuild, Vite, Angular's esbuild builder) can't resolve echarts-gl's deep imports when it is consumed from source (echarts-gl/charts,echarts-gl/components,import 'echarts-gl'). Full details and a minimal repro are in #574.The target files and their named exports are unchanged in echarts 6 / zrender 6 — only the
.jsextension was missing from the import specifiers. So this is a purely mechanical change:.jsform).Verification
echarts-gl/chartsagainst echarts 6.1.0 + zrender 6.1.0 resolves cleanly and registersscatter3D/grid3D(the same bundle fails with several "Could not resolve" errors without this change).Fixes #574