Open
Conversation
This was referenced Jun 22, 2022
leelasn
approved these changes
Nov 1, 2022
|
Any update here? Am running into the same compilation warnings on |
Using the recommended export from for umd mentioned in https://devblogs.microsoft.com/typescript/writing-dts-files-for-types/
Author
|
There was some improvements to the type surrounding the ChangeType and FileType, but the default export is still the same, so I've rebased this PR let's see if we can get it in 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type export is malformed and gives errors in current versions of typescript
This also does not work if you want to use
gitDiffParserglobally (not importing). Since theindex.jsexports as a UMD, I followed the example https://devblogs.microsoft.com/typescript/writing-dts-files-for-types/With this type, all the following works
As a bonus I added exports for
FileTypeandChangeType.