Skip to content

Fix: accommodate ID types pulled from EDU #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johncmerfeld merged 1 commit into from
Jun 3, 2026
Merged

Fix: accommodate ID types pulled from EDU #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion executor/executor/executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,7 +626,8 @@ def unpack_id_types(self):
try:
for id_code in record["studentIdentificationCodes"]:
# a given roster record may have several ID descriptors with different values
id_type = id_code["studentIdentificationSystemDescriptor"].split("#")[1]
# using split()[-1] here because it's possible for these ID types to have a full descriptor URI, and also for them to be bare
id_type = id_code["studentIdentificationSystemDescriptor"].split("#")[-1]
if id_type not in id_types:
id_types[id_type] = {
"stu_id_matches": 0,
Expand Down