Improve CI

[eddiet19]

No description provided.

[github-learning-lab]

Matrix builds

Great work so far! By targeting specific versions of Node, we've configured a build matrix which allow us to test across multiple operating systems, platforms, and language versions. See Configuring a matrix build in GitHub Help if you'd like to learn more.

I'll respond when you commit the changes in the comment below.

[github-learning-lab]

Step 8: Target a Windows environment

Since we'd like to support deploying our app to Windows environments, let's add Windows to the matrix build configuration.

⌨️ Activity: Edit your workflow file to build for Windows environments

You can follow the suggestion, or manually make the changes in the numbered instructions.

Suggested change

	node-version: [12.x, 14.x]
	os: [ubuntu-latest, windows-2016]
	node-version: [12.x, 14.x]

1. Edit the workflow config at .github/workflows/nodejs.yml
2. Add an os field to the strategy.matrix section of your workflow
3. Add ubuntu-latest and windows-2016 to the target operating systems
4. Commit your workflow changes to this branch.

I'll respond in this pull request when you've committed.

[github-learning-lab]

New Job

Great, if you look at the logs now, you'll notice that multiple builds will exist: 4 build to be exact! That's because for each of the 2 operating systems we're running tests against 2 versions so: 2 OS ✖️ 2 Node.js versions = 4 builds.

Our custom workflow now accounts for:

• ✅ test against multiple targets so that we know if our supported operating systems and Node.js versions are working

Step 9: Use multiple jobs

Let's now try to create a dedicated test job and satisfy the second item in our custom workflow checklist.

This will allow us to separate the build and test functions of our workflow into more than one job that will run when our workflow is triggered.

Activity: Edit your workflow file to separate build and test jobs

1. Edit your workflow file
2. Create a new job called "test" as follows (we'll use ellipses ... to only show the parts of the workflow we're interested in, but you should not copy the ellipses directly):

   name: Node CI
   
   on: [push]
   
   jobs:
     build:
       ...
     test:
       ...

3. In the build job, include the following portions of your existing workflow:

   build:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
       - name: npm install and build webpack
         run: |
           npm install
           npm run build

4. In the newly created test job, include the following portions of your existing workflow:

   test:
     runs-on: ubuntu-latest
     strategy:
       matrix:
         os: [ubuntu-latest, windows-2016]
         node-version: [12.x, 14.x]
     steps:
     - uses: actions/checkout@v2
     - name: Use Node.js ${{ matrix.node-version }}
       uses: actions/setup-node@v1
       with:
         node-version: ${{ matrix.node-version }}
     - name: npm install, and test
       run: |
         npm install
         npm test
       env:
         CI: true

If you'd like to copy and paste the full workflow file instead, click here to see it in its entirety.

name: Node CI

on: [push]

jobs:
  build:

    runs-on: ubuntu-latest

    steps:
      - uses: actions/checkout@v2
      - name: npm install and build webpack
        run: |
          npm install
          npm run build

  test:

    runs-on: ubuntu-latest

    strategy:
      matrix:
        os: [ubuntu-latest, windows-2016]
        node-version: [12.x, 14.x]

    steps:
    - uses: actions/checkout@v2
    - name: Use Node.js ${{ matrix.node-version }}
      uses: actions/setup-node@v1
      with:
        node-version: ${{ matrix.node-version }}
    - name: npm install, and test
      run: |
        npm install
        npm test
      env:
        CI: true

When you commit to this branch, the workflow should run again. I'll respond when it is finished running.

---

Actions workflow not running? Click here

When a GitHub Actions workflow is running, you should see some checks in progress, like the screenshot below.

If the checks don't appear or if the checks are stuck in progress, there's a few things you can do to try and trigger them:

• Refresh the page, it's possible the workflow ran and the page just hasn't been updated with that change
• Try making a commit on this branch. Our workflow is triggered with a push event, and committing to this branch will result in a new push
• Edit the workflow file on GitHub and ensure there are no red lines indicating a syntax problem