Conversation
edelooff
reviewed
Nov 26, 2023
Comment on lines
+184
to
+190
| def test_null_none(session): | ||
| """ | ||
| Make sure library can handle both None and null() as JSON value | ||
| """ | ||
| for value in (None, null()): | ||
| author = Author(name="John Doe", handles=value) | ||
| Article(author=author.name, content="very important", references=value) |
Owner
There was a problem hiding this comment.
Instead of having the test fail when either of these fail, parametrize over the different null-like values:
Suggested change
| def test_null_none(session): | |
| """ | |
| Make sure library can handle both None and null() as JSON value | |
| """ | |
| for value in (None, null()): | |
| author = Author(name="John Doe", handles=value) | |
| Article(author=author.name, content="very important", references=value) | |
| @pytest.mark.parametrize("null_like", [None, null()]) | |
| def test_null_like_assignments(null_like): | |
| """Make sure library can handle both None and null() as JSON value.""" | |
| author = Author(name="John Doe", handles=null_like) | |
| assert author.handles is None |
Owner
|
Apologies for the delay. The change looks good but the testing needs a small change to separate the two actual tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for Issue #55