feat: manage system settings (timezone, location, scheduler interval) from the app#55
Merged
Merged
Conversation
… from the app Move timezone, latitude/longitude and the optimization scheduler interval out of environment variables and into user-editable, database-backed settings. Core: - SystemConfiguration value object and SystemConfigurationUpdated domain event - ConfigurationService.get_system_configuration / update_system_configuration with validation, persisted through the existing settings store (no migration) - Runtime propagation via the event bus: refresh the application timezone, reconfigure the Sun-calculation location and reschedule the evaluation job without a restart - Encapsulated timezone state in a TimezoneProvider; AstralSunFactory.reconfigure() - Remove TIMEZONE, LATITUDE, LONGITUDE and SCHEDULER_INTERVAL_SECONDS env variables API: - GET/PUT /api/v1/system/settings Frontend: - System settings page with a browser-sourced timezone list and an interactive dark Leaflet map to pick the location (draggable marker using the Edge Mining logo) Tests: - Schema, service and handler unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54
Closes #8
Overview
Move timezone, location (latitude/longitude) and the optimization scheduler interval out of environment variables and into user-editable, database-backed settings, manageable from a new "System" settings page.
Core
SystemConfigurationvalue object andSystemConfigurationUpdateddomain event.ConfigurationService.get_system_configuration()/update_system_configuration()with validation (valid IANA timezone, latitude/longitude ranges, positive interval), persisted through the existing settings store (no migration).AstralSunFactory.reconfigure());TimezoneProvider.TIMEZONE,LATITUDE,LONGITUDEandSCHEDULER_INTERVAL_SECONDSenvironment variables; defaults are seeded on first run.API
GET/PUT /api/v1/system/settings.Frontend
Tests
Notes