fix(home-assistant): allow partial forecast entity configuration#56
Draft
Herbertmt978 wants to merge 1 commit into
Draft
fix(home-assistant): allow partial forecast entity configuration#56Herbertmt978 wants to merge 1 commit into
Herbertmt978 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hi! This is a small backend-focused improvement related to #31.
Why
The Home Assistant forecast schema presents its entity IDs as optional, and the provider already skips missing entities while returning the data that is available. Two builder guards still required the current-hour power and energy entities, so otherwise valid partial configurations failed during adapter initialization.
Removing those guards aligns initialization with the provider's existing partial-data behavior.
Scope
This intentionally stays small and backend-focused. It does not implement the broader form validation or UI status/error handling discussed in #31, and it is not intended to close #31.
Refs #31
Validation
python -m pytest core/tests/unit/adapters/domain/forecast/test_home_assistant_api.py -q— 1 passed.python -m pytest core/tests/unit -q— 557 passed, 44 skipped (optionalskforecastcoverage was unavailable locally).python -m ruff format --check edge_mining tests— 382 files already formatted.python -m ruff check edge_mining— passed.python -m pytest core/tests -q— 603 passed and 44 skipped, but the command exited non-zero with 7 Windows-only persistence teardown errors. Each wasPermissionError: [WinError 32]while deleting a still-open temporary SQLite database; these integration cleanup paths are outside this change.