refactor(datasets-raw): move block streaming traits from common #1609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract block streaming functionality into datasets-raw crate to improve separation of concerns and reduce common crate's scope. - Move `BlockStreamer` and `BlockStreamerExt` traits from `common` to `datasets-raw::client` - Add `Rows` and `TableRows` types with typed error enums - Replace `BoxError` with `TableRowError` and `CheckInvariantsError` - Update all extractors to use new module paths Signed-off-by: Lorenzo Delgado <lorenzo@edgeandnode.com>
LNSD
force-pushed
the
lnsd/refactor-datasets-raw-extractors-tentacle
branch
from
dbfabf1 to
a6e0aeb
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Remove dead code that provides no value over struct literal syntax since all fields are public. - Constructor had zero usage across entire codebase - All existing code uses struct literals directly - No validation or transformation logic in constructor - Simplifies API by eliminating redundant construction method Signed-off-by: Lorenzo Delgado <lorenzo@edgeandnode.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract block streaming functionality into datasets-raw crate to improve separation of concerns and reduce common crate's scope.
BlockStreamerandBlockStreamerExttraits fromcommontodatasets-raw::clientRowsandTableRowstypes with typed error enumsBoxErrorwithTableRowErrorandCheckInvariantsErrorNote
Separates raw data extraction concerns and tightens type safety across the codebase.
datasets-rawwithclient::{BlockStreamer, BlockStreamerExt}(moved fromcommon) and a retry wrapper; updatesdataset-store,dump, and all extractors to use itdatasets-raw::rows::{Rows, TableRows}with invariant checks and typed errors (TableRowError,CheckInvariantsError); replacescommon::RawTableRowsBlockRangetodatasets-common::block_rangeand adjusts imports; simplifiescommonexports and updatesWatermarkconstruction (From<&BlockRange>)TableRows; updates streaming/compaction/parquet writers to use new typesdatasets-rawand newdatasets-commonusage; minor API renames (e.g., publicBlockStreamClient) and test/import fixesWritten by Cursor Bugbot for commit 6b103a0. This will update automatically on new commits. Configure here.