fix: always use codejail.safe_exec.safe_exec when executing code
#26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage of unsafely is determined by the setting `COURSES_WITH_UNSAFE_CODE` in the edx-platform code, when True, the jailed code would skip the sandboxed environment and run directly on the service environment. Allowing the use of unsafely through an HTTP call is an unnecesary vector.
MoisesGSalas
force-pushed
the
mgs/remove-unsafely
branch
from
ad5ce81 to
e64d01a
Compare
felipemontoya
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage of unsafely is determined by the setting
COURSES_WITH_UNSAFE_CODEin the edx-platform code, when True, the jailed code would skip the sandboxed environment and run directly on the service environment.Allowing the use of unsafely through an HTTP call is an unnecesary vector.