Skip to content

fix: set FLASK_APP_SETTINGS env for k8s-deployment#65

Merged
MoisesGSalas merged 1 commit intoeduNEXT:mainfrom
raccoongang:max/fix/flask-settings
Apr 2, 2025
Merged

fix: set FLASK_APP_SETTINGS env for k8s-deployment#65
MoisesGSalas merged 1 commit intoeduNEXT:mainfrom
raccoongang:max/fix/flask-settings

Conversation

@cmltaWt0
Copy link
Contributor

The FLASK_APP_SETTINGS is missing for k8s-deployment causing the usage of the default Production config only.

@cmltaWt0 cmltaWt0 requested review from a team and MoisesGSalas as code owners March 17, 2025 18:37
@MoisesGSalas
Copy link
Member

Thanks, in theory this shouldn't affect anyone in k8s because the default when unset was codejailservice.config.ProductionConfig

@MoisesGSalas MoisesGSalas merged commit 8444cce into eduNEXT:main Apr 2, 2025
2 of 3 checks passed
@cmltaWt0
Copy link
Contributor Author

cmltaWt0 commented Apr 2, 2025

@MoisesGSalas Thanks!
The defaults are okay for a default configuration. However, we ended up with a completely broken instance (students ran crazy code without any restrictions – so the default configuration wasn't great) due to the absence of tutor patching. We needed to set the correct LIMITS, but were unable to do so because of the misconfiguration and lack of patching.

@MoisesGSalas
Copy link
Member

On the topic of LIMITS, you might want to read the findings that Tim have been documenting related to NPROC: openedx/codejail#239. Is particularly relevant in the k8s case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants