fix: set FLASK_APP_SETTINGS env for k8s-deployment#65
Merged
MoisesGSalas merged 1 commit intoeduNEXT:mainfrom Apr 2, 2025
Merged
fix: set FLASK_APP_SETTINGS env for k8s-deployment#65MoisesGSalas merged 1 commit intoeduNEXT:mainfrom
MoisesGSalas merged 1 commit intoeduNEXT:mainfrom
Conversation
Member
|
Thanks, in theory this shouldn't affect anyone in k8s because the default when unset was |
MoisesGSalas
approved these changes
Apr 2, 2025
Contributor
Author
|
@MoisesGSalas Thanks! |
Member
|
On the topic of LIMITS, you might want to read the findings that Tim have been documenting related to NPROC: openedx/codejail#239. Is particularly relevant in the k8s case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
FLASK_APP_SETTINGSis missing for k8s-deployment causing the usage of the default Production config only.