Fix B3 (Vec reverse iterator return types) and B1 (ABF lambda update index)#29
Merged
csparker247 merged 2 commits intodevelopfrom Mar 14, 2026
Merged
Fix B3 (Vec reverse iterator return types) and B1 (ABF lambda update index)#29csparker247 merged 2 commits intodevelopfrom
csparker247 merged 2 commits intodevelopfrom
Conversation
…index) B3: rbegin/rend/crbegin/crend returned iterator/const_iterator instead of reverse_iterator/const_reverse_iterator, preventing correct reverse iteration. B1: The interior-vertex lambda update loop used idx+intIdx where both incremented each iteration, producing wrong delta offsets for meshes with 2+ interior vertices. Fixed by capturing a fixed base = edgeCnt+faceCnt before the loop. Includes TDD tests (T1-T4) written prior to these fixes: multi-interior-vertex grid parameterization tests, FindEdgePath disconnected-mesh test, OBJ/PLY round-trip IO tests with vertex position assertions, and Vec reverse iteration tests. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
csparker247
added a commit
that referenced
this pull request
Mar 14, 2026
All six tracks were resolved via PR #29 (merged to develop): B1, B3 fixed; T1-T4 tests written and passing. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was
linked to
issues
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
include/OpenABF/Vec.hpp):rbegin/rend/crbegin/crenddeclared to returniterator/const_iteratorinstead ofreverse_iterator/const_reverse_iterator, preventing correct reverse iteration and causing compilation errors when reverse iterators are used.include/OpenABF/ABF.hpp): Interior-vertex lambda update loop usedidx + intIdxwhere both variables incremented each iteration, producing wrong delta offsets for meshes with 2+ interior vertices. Fixed by capturing a fixedbase = edgeCnt + faceCntbefore the loop, matching the correct pattern already used inABFPlusPlus.TDD Tests (T1–T4)
Added prior to the fixes as regression coverage:
ConstructGridfixture + multi-interior-vertex parameterization tests (ABF_MultiInterior,ABFPlusPlus_MultiInterior,ABF_NoInteriorVertices,ABF_MaxIters)FindEdgePathdisconnected-mesh testVecreverse iteration test (rbegin/rend/crbegin/crend)Test plan
ctest100%)ABF_MultiInteriornow passes on the 4×4 grid (was crashing before B1 fix)Vec::ReverseIterationnow compiles and passes (was compile error before B3 fix)Closes #6, #8, #21, #22, #23, #24