Skip to content

Add defensive quoting and tighten mise trust scope #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edwinhern merged 3 commits into from
Jun 26, 2026
Merged

Add defensive quoting and tighten mise trust scope #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35ae1e7
refactor: clean up nvim plugin specs
edwinhern Jun 26, 2026
4514025
fix: quote template values and scope mise trust
edwinhern Jun 26, 2026
242345b
fix: drop leaked nvim files from template PR
edwinhern Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions home/.chezmoitemplates/apm/mcp-server.yml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
- name: {{ index . "name" }}
- name: "{{ index . "name" }}"
registry: {{ index . "registry" }}
transport: {{ index . "transport" }}
{{- if hasKey . "url" }}
url: {{ index . "url" }}
url: "{{ index . "url" }}"
{{- end }}
{{- if hasKey . "headers" }}
headers:
Expand All @@ -11,7 +11,7 @@
{{- end }}
{{- end }}
{{- if hasKey . "command" }}
command: {{ index . "command" }}
command: "{{ index . "command" }}"
{{- end }}
{{- if hasKey . "args" }}
args:
Expand Down
4 changes: 2 additions & 2 deletions home/dot_apm/apm.yml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ dependencies:
{{- with .skills }}
skills:
{{- range . }}
- {{ . }}
- "{{ . }}"
{{- end }}
{{- end }}
{{- else }}
- {{ . }}
- "{{ . }}"
{{- end }}
{{ end }}
{{ end -}}
Expand Down
4 changes: 2 additions & 2 deletions home/dot_config/git/config.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[user]
name = {{ .git.name }}
email = {{ .git.email }}
name = "{{ .git.name }}"
email = "{{ .git.email }}"
[core]
editor = code --wait
pager = delta
Expand Down
2 changes: 1 addition & 1 deletion home/dot_config/mise/config.toml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@

[settings]
idiomatic_version_file_enable_tools = ["node", "python", "pnpm"]
trusted_config_paths = ["/"]
trusted_config_paths = ["~"]
34 changes: 17 additions & 17 deletions tests/template/apm-config.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ render_apm_template() {
run render_apm_template "$PERSONAL_DATA"

assert_success
assert_line ' - name: grep'
assert_line ' - name: "grep"'
assert_line ' registry: false'
assert_line ' url: https://mcp.grep.app'
assert_line ' url: "https://mcp.grep.app"'
refute_line --regexp 'name: figma'
refute_line --regexp 'name: jira'
}
Expand All @@ -41,15 +41,15 @@ render_apm_template() {
run render_apm_template "$PERSONAL_DATA"

assert_success
assert_line --partial ' - obra/superpowers'
assert_line --partial ' - JuliusBrussee/caveman'
assert_line --partial ' - anthropics/claude-plugins-official/plugins/skill-creator'
assert_line --partial ' - schpet/linear-cli'
assert_line --partial ' - tavily-ai/skills'
assert_line --partial ' - "obra/superpowers'
assert_line --partial ' - "JuliusBrussee/caveman'
assert_line --partial ' - "anthropics/claude-plugins-official/plugins/skill-creator'
assert_line --partial ' - "schpet/linear-cli'
assert_line --partial ' - "tavily-ai/skills'
assert_line --partial ' - git: JuliusBrussee/skills'
assert_line ' skills:'
assert_line ' - grill-me'
assert_line ' - junior-to-senior'
assert_line ' - "grill-me"'
assert_line ' - "junior-to-senior"'
refute_line --partial 'interface-kit'
refute_line --partial 'loop-factory'
refute_line --partial 'context-canary'
Expand All @@ -59,11 +59,11 @@ render_apm_template() {
run render_apm_template "$WORK_DATA"

assert_success
assert_line ' - name: grep'
assert_line ' - name: figma'
assert_line ' url: https://mcp.figma.com/mcp'
assert_line ' - name: jira'
assert_line ' url: https://mcp.atlassian.com/v1/mcp'
assert_line ' - name: "grep"'
assert_line ' - name: "figma"'
assert_line ' url: "https://mcp.figma.com/mcp"'
assert_line ' - name: "jira"'
assert_line ' url: "https://mcp.atlassian.com/v1/mcp"'
}

@test "work APM config renders work target" {
Expand All @@ -81,9 +81,9 @@ render_apm_template() {
run render_apm_template "$WORK_DATA"

assert_success
assert_line --partial ' - obra/superpowers'
assert_line --partial ' - JuliusBrussee/caveman'
assert_line --partial ' - anthropics/claude-plugins-official/plugins/skill-creator'
assert_line --partial ' - "obra/superpowers'
assert_line --partial ' - "JuliusBrussee/caveman'
assert_line --partial ' - "anthropics/claude-plugins-official/plugins/skill-creator'
refute_line --partial ' - schpet/linear-cli'
refute_line --partial ' - tavily-ai/skills'
refute_line --partial 'JuliusBrussee/skills'
Expand Down
Loading