fix: Ignore supervisor "already started" when ensuring edxapp workers…

[srathod-apphelix]

Summary

• Treat supervisor ERROR (already started) as success when ensuring edxapp_worker processes are started.
• Keep the existing deploy flow: config update → ensure running → restart to load new code.
• Apply the same fix in all edxapp deploy.yml role copies.

Jira - GSRE-4236

Purpose

CreateSandbox fails only when enable_datadog=true because Datadog changes worker startup scripts (ddtrace-run), so supervisorctl update starts the workers, and the later ensure edxapp_workers has started task fails with:
edxapp_worker:cms_default_1: ERROR (already started)
This change makes that condition non-fatal so sandbox provisioning can continue, while the final restart edxapp_workers task still reloads the newly deployed code.

Changes

• playbooks/roles/edxapp/tasks/deploy.yml

[Copilot]

Pull request overview

Adjusts the edxapp deploy flow to tolerate Supervisor’s ERROR (already started) when ensuring edxapp_worker processes are started, preventing sandbox provisioning failures when Datadog instrumentation causes workers to be started earlier in the run.

Changes:

• Registers the supervisorctl “ensure edxapp_workers has started” task result.
• Adds a failed_when guard to treat “already started” as non-fatal for that task.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

playbooks/roles/edxapp/tasks/deploy.yml:509

• failed_when references edxapp_workers_start.failed directly. In Ansible, registered results may not have a failed attribute on success, and accessing a missing attribute inside a conditional can raise an error (elsewhere in this repo, similar logic is guarded with ...failed is defined, e.g. playbooks/roles/mongo_7_0/tasks/main.yml:102). Guard the access so successful runs don’t error while evaluating this expression.

  failed_when: >
    edxapp_workers_start is failed and
    'already started' not in edxapp_workers_start.msg

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.