feat: B2C Subscription Inclusion Flag for Program Algolia Reindex#61
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Algolia proxy model layer to rely on the underlying Program.b2c_subscription_inclusion model field (instead of a custom proxy property) and removes the corresponding Algolia-model tests for programs.
Changes:
- Removed the
AlgoliaProxyProgram.b2c_subscription_inclusionproperty override inalgolia_models.py. - Deleted program-focused
b2c_subscription_inclusiontests fromtest_algolia_models.py.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
course_discovery/apps/course_metadata/algolia_models.py |
Removes the program-level b2c_subscription_inclusion override in the Algolia proxy model implementation. |
course_discovery/apps/course_metadata/tests/test_algolia_models.py |
Removes program b2c_subscription_inclusion tests near the end of the Algolia proxy program test suite. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
754
to
756
|
|
||
|
|
||
| class SearchDefaultResultsConfiguration(models.Model): |
| def b2c_subscription_inclusion(self, value): | ||
| self.__dict__['_b2c_subscription_inclusion'] = value | ||
|
|
||
|
|
Comment on lines
963
to
965
| 'translation_languages': [], | ||
| 'transcription_languages': [] | ||
| } |
skumargupta83
force-pushed
the
SUBS/ENHA-820
branch
from
July 23, 2026 17:07
49634db to
fe933ea
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
course_discovery/apps/course_metadata/tests/test_algolia_models.py:964
- The program-focused b2c_subscription_inclusion tests were removed, leaving no coverage in this module that AlgoliaProxyProgram exposes/persists the flag correctly. Adding at least one focused regression test would help ensure the field continues to be included for program indexing.
def test_program_ai_languages(self):
program = AlgoliaProxyProgramFactory(partner=self.__class__.edxPartner)
assert program.product_ai_languages == {
'translation_languages': [],
'transcription_languages': []
Comment on lines
747
to
751
| @property | ||
| def product_external_url(self): | ||
| if hasattr(self, 'degree') and hasattr(self.degree, 'additional_metadata'): | ||
| return self.degree.additional_metadata.external_url | ||
| else: |
skumargupta83
force-pushed
the
SUBS/ENHA-820
branch
from
July 23, 2026 17:15
fe933ea to
bbc9f8b
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
course_discovery/apps/course_metadata/tests/test_algolia_models.py:965
- The PR removes all AlgoliaProxyProgram tests covering b2c_subscription_inclusion. Since the Algolia reindex uses the proxy model (not the base Program model), it’s useful to keep at least one proxy-level test to guard against regressions where the proxy accidentally shadows or mis-reads the database-backed field (which wouldn’t be caught by course_metadata/tests/test_models.py’s ProgramFactory tests).
def test_program_ai_languages(self):
program = AlgoliaProxyProgramFactory(partner=self.__class__.edxPartner)
assert program.product_ai_languages == {
'translation_languages': [],
'transcription_languages': []
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.