fix: dev.migrate.<service> and <service>-migrate for several services#226
Open
pwnage101 wants to merge 1 commit into
Open
fix: dev.migrate.<service> and <service>-migrate for several services#226pwnage101 wants to merge 1 commit into
pwnage101 wants to merge 1 commit into
Conversation
Our IDA Dockerfiles are not consistent about where the app source code or virual environment is installed. Meanwhile, this mgirate target hard-codes the path which only works for half of them. The outcome is that, e.g., `make enterprise-access-migrate` never worked and that really grinds my gears. The fix is to just not hard-code any paths at all.
pwnage101
force-pushed
the
pwnage101/fix-migrate-target
branch
from
July 24, 2026 23:55
562918b to
4c087db
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates devstack’s migration-related targets to avoid relying on hard-coded in-container source paths, which have drifted across service images over time.
Changes:
- Add
enterprise-catalogto the set of DB-backed services used for generating migration targets. - Simplify
dev.migrate.%to runmake migratedirectly inside the target service container.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| options.mk | Updates the DB-backed services list to include enterprise-catalog. |
| Makefile | Changes generic migration execution to run make migrate directly in the container, avoiding hard-coded cd/source paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
78
to
+79
| DB_SERVICES ?= \ | ||
| credentials+cms+discovery+ecommerce+enterprise-access+enterprise-subsidy+lms+registrar+license-manager | ||
| credentials+cms+discovery+ecommerce+enterprise-access+enterprise-catalog+enterprise-subsidy+lms+registrar+license-manager |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
options.mk:79
- DB_SERVICES is documented as "Listed in alphabetical order for clarity", but the updated list is still out of order (e.g., license-manager appears after registrar). Reordering keeps the list consistent with the comment and easier to scan.
credentials+cms+discovery+ecommerce+enterprise-access+enterprise-catalog+enterprise-subsidy+lms+registrar+license-manager
Comment on lines
220
to
+221
| dev.migrate.%: ## Run migrations on a service. | ||
| docker compose exec $* bash -c 'source /edx/app/$*/$*_env && cd /edx/app/$*/$*/ && make migrate' | ||
| docker compose exec $* make migrate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our IDA Dockerfiles are not consistent about where the app source code or virual environment is installed. Meanwhile, this mgirate target hard-codes the path which only works for half of them. The outcome is that, e.g.,
make enterprise-access-migratenever worked and that really grinds my gears.The fix is to just not hard-code any paths at all.
Also, add enterprise-catalog to the list of supported services for this migrate command, so
make enterprise-catalog-migratenow works too.