feat: enable edxnotes by default and add OAuth client fixture for tests#388
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR turns Student Notes (edxnotes) on by default at the course-field level (while still gated by the platform-level FEATURES['ENABLE_EDXNOTES'] flag), and updates test infrastructure so the edxnotes decorator can run safely in the test environment.
Changes:
- Changed
InheritanceMixin.edxnotesdefault fromFalsetoTrue, enabling Notes by default for courses that don’t explicitly override the field. - Added an autouse pytest fixture to ensure the edx-notes OAuth2
Applicationexists in DB-backed Django unittest-style tests whenENABLE_EDXNOTESis enabled. - Patched/updated a handful of tests to explicitly disable/enable
ENABLE_EDXNOTESas needed for mock runtime limitations and updated expectations.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
xmodule/modulestore/inheritance.py |
Enables edxnotes by default via course-field default change. |
conftest.py |
Adds an autouse fixture to create the edx-notes OAuth2 client in tests when needed. |
xmodule/tests/test_split_test_block.py |
Disables ENABLE_EDXNOTES for split test classes to avoid mock runtime rendering issues. |
openedx/core/djangoapps/course_apps/tests/test_notes_app.py |
Updates test expectations to match “enabled by default” behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alenkadev
force-pushed
the
alenka/turn-on-notes
branch
from
July 17, 2026 07:07
efdda41 to
3a554f8
Compare
alenkadev
force-pushed
the
alenka/turn-on-notes
branch
from
July 17, 2026 07:19
3a554f8 to
45940a9
Compare
alenkadev
force-pushed
the
alenka/turn-on-notes
branch
from
July 21, 2026 10:02
45940a9 to
d3de2db
Compare
rpipaliya-sonata
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Summary
Enables the Student Notes feature by default for all courses by changing InheritanceMixin.edxnotes default from False to True, so courses no longer require manual opt-in via Advanced Settings when the platform-level ENABLE_EDXNOTES flag is on.
Jira: LP-952: turn Notes on by default](https://2u-internal.atlassian.net/browse/LP-952)