Skip to content

profiles: decouple "board_name" and "profile" from "platform" variable#71

Open
map-b wants to merge 1 commit intoefahl:mainfrom
map-b:profiles-decouple-device-platform
Open

profiles: decouple "board_name" and "profile" from "platform" variable#71
map-b wants to merge 1 commit intoefahl:mainfrom
map-b:profiles-decouple-device-platform

Conversation

@map-b
Copy link
Copy Markdown

@map-b map-b commented Apr 2, 2026

Just separate the, now a bit overloaded, variable "device.platform" which represents: the board_name(dts compatible) and profile into two explicit variables trying to make clearer the profile identification process during ASU sysupgrades.

The old "sanitized" device.platform now would be "device.profile" while the raw board_name is kept in "device.board_name".

In the mapping case code, rename "real_platform" to "platform_profile" and "alias" to "dts_compatible" in order to make clearer the translation/mapping being done: dts_compatible(board_name) -> profile

Rename standalone "profile" to a more representative "platform_profile" since it represents a tuple from the platform dictionary (profiles.json).

Adapted some log outputs and show the two variables when printing the previous single "device.platform".

No change in the logic, nothing should be different after this change.

Just separate the, now a bit overloaded, variable "device.platform" which
represents: the board_name(dts compatible) and profile into two explicit
variables trying to make clearer the profile identification process
during ASU sysupgrades.

The old "sanitized" device.platform now would be "device.profile" while
the raw board_name is kept in "device.board_name".

In the mapping case code, rename "real_platform" to "platform_profile"
and "alias" to "dts_compatible" in order to make clearer the
translation/mapping being done: dts_compatible(board_name) -> profile

Rename standalone "profile" to a more representative "platform_profile"
since it represents a tuple from the platform dictionary (profiles.json).

Adapted some log outputs and show the two variables when printing the
previous single "device.platform".

No change in the logic, nothing should be different after this change.
@map-b
Copy link
Copy Markdown
Author

map-b commented Apr 2, 2026

Hello Eric, I am really hope we can agree at least with these renames... I finally got time to look into owut code, and I can understand your concerns... it is a bit confusing, you mostly implemented this code about two years ago and I suppose your were mainly using the special x86 /"generic" case.

There should not be any logic change. In most cases board_name and profile would the same (replacing(',', '-')) but we know that it is important to know/show both. I was going to make some in-line comments in the PR to expand the reasoning but I do not know. I'll wait for your first comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant