Skip to content

refactor: clean up imports and adjust task retrieval order #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MhmdSinanKT wants to merge 1 commit into
base: version-15
Choose a base branch
from
Open

refactor: clean up imports and adjust task retrieval order #614

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions one_compliance/one_compliance/doc_events/project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,11 @@
import frappe
from frappe import _
from frappe.email.doctype.notification.notification import get_context
from frappe.utils import add_days, getdate, today
from one_compliance.one_compliance.utils import create_todo
from one_compliance.one_compliance.doc_events.task import (
create_sales_order,
get_rate_from_compliance_agreement,
update_expected_dates_in_task,
)
from frappe.utils import getdate, today
from one_compliance.one_compliance.doc_events.task import update_expected_dates_in_task
from one_compliance.one_compliance.utils import (
create_project_completion_todos,
create_todo,
send_notification,
)

Expand Down Expand Up @@ -181,10 +177,6 @@ def create_tasks_from_template(project):
created_tasks = []

for template_task in template_doc.tasks:
template_task_doc = None
if template_task.task:
template_task_doc = frappe.get_doc("Task", template_task.task)

task = frappe.new_doc("Task")
task.compliance_sub_category = project_doc.compliance_sub_category
task.subject = template_task.subject
Expand Down Expand Up @@ -227,7 +219,7 @@ def get_project_tasks(project):
"Task",
filters={"project": project},
fields=["name", "subject", "status", "completed_by", "completed_on"],
order_by="modified desc"
order_by="creation asc"
)

has_completed = any(t.status == "Completed" for t in tasks)
Expand Down