Skip to content

fix: change naming series of feasibility check doctype and edit feasibility check workflow #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anshidakk wants to merge 1 commit into
base: v3_develop
Choose a base branch
from
Open

fix: change naming series of feasibility check doctype and edit feasibility check workflow #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 29 additions & 41 deletions versa_system/fixtures/workflow.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
"doctype": "Workflow",
"document_type": "Design Request",
"is_active": 0,
"modified": "2025-01-07 16:31:38.969064",
"modified": "2025-01-09 12:21:39.459668",
"name": "Design Request workflow",
"override_status": 0,
"send_email_alert": 0,
"states": [
{
"allow_edit": "Administrator",
"allow_edit": "Lead User",
"avoid_status_override": 0,
"doc_status": "0",
"is_optional_state": 0,
Expand All @@ -25,7 +25,7 @@
"workflow_builder_id": null
},
{
"allow_edit": "Administrator",
"allow_edit": "Lead User",
"avoid_status_override": 0,
"doc_status": "0",
"is_optional_state": 0,
Expand Down Expand Up @@ -74,7 +74,7 @@
{
"action": "Send to Customer",
"allow_self_approval": 1,
"allowed": "Administrator",
"allowed": "Lead User",
"condition": null,
"next_state": "Sent to Customer",
"parent": "Design Request workflow",
Expand Down Expand Up @@ -129,13 +129,13 @@
"doctype": "Workflow",
"document_type": "Quotation",
"is_active": 1,
"modified": "2025-01-08 10:11:56.828411",
"modified": "2025-01-10 12:54:32.544262",
"name": "Quotation Workflow",
"override_status": 0,
"send_email_alert": 0,
"states": [
{
"allow_edit": "Administrator",
"allow_edit": "Lead User",
"avoid_status_override": 0,
"doc_status": "0",
"is_optional_state": 0,
Expand All @@ -150,7 +150,7 @@
"workflow_builder_id": null
},
{
"allow_edit": "Administrator",
"allow_edit": "Lead User",
"avoid_status_override": 0,
"doc_status": "0",
"is_optional_state": 0,
Expand Down Expand Up @@ -214,7 +214,7 @@
{
"action": "Send to Customer",
"allow_self_approval": 1,
"allowed": "Administrator",
"allowed": "Lead User",
"condition": null,
"next_state": "Sent to Customer",
"parent": "Quotation Workflow",
Expand All @@ -226,7 +226,7 @@
{
"action": "Send to Customer",
"allow_self_approval": 1,
"allowed": "Administrator",
"allowed": "Lead User",
"condition": null,
"next_state": "Sent to Customer",
"parent": "Quotation Workflow",
Expand All @@ -238,7 +238,7 @@
{
"action": "Send to Customer",
"allow_self_approval": 1,
"allowed": "Administrator",
"allowed": "Lead User",
"condition": null,
"next_state": "Sent to Customer",
"parent": "Quotation Workflow",
Expand All @@ -250,7 +250,7 @@
{
"action": "Send to Customer",
"allow_self_approval": 1,
"allowed": "Administrator",
"allowed": "Lead User",
"condition": null,
"next_state": "Sent to Customer",
"parent": "Quotation Workflow",
Expand Down Expand Up @@ -304,14 +304,14 @@
"docstatus": 0,
"doctype": "Workflow",
"document_type": "Design Request",
"is_active": 1,
"modified": "2025-01-08 10:03:34.771967",
"is_active": 0,
"modified": "2025-01-13 10:47:48.496215",
"name": "Mockup Workflow",
"override_status": 0,
"send_email_alert": 0,
"states": [
{
"allow_edit": "Administrator",
"allow_edit": "Lead User",
"avoid_status_override": 0,
"doc_status": "0",
"is_optional_state": 0,
Expand Down Expand Up @@ -371,7 +371,7 @@
"workflow_builder_id": null
},
{
"allow_edit": "Administrator",
"allow_edit": "Lead User",
"avoid_status_override": 0,
"doc_status": "0",
"is_optional_state": 0,
Expand All @@ -390,7 +390,7 @@
{
"action": "Send to Customer",
"allow_self_approval": 1,
"allowed": "Administrator",
"allowed": "Lead User",
"condition": null,
"next_state": "Sent to Customer",
"parent": "Mockup Workflow",
Expand All @@ -402,7 +402,7 @@
{
"action": "Send to Customer",
"allow_self_approval": 1,
"allowed": "Administrator",
"allowed": "Lead User",
"condition": null,
"next_state": "Sent to Customer",
"parent": "Mockup Workflow",
Expand All @@ -414,7 +414,7 @@
{
"action": "Send to Customer",
"allow_self_approval": 1,
"allowed": "Administrator",
"allowed": "Lead User",
"condition": null,
"next_state": "Sent to Customer",
"parent": "Mockup Workflow",
Expand All @@ -426,19 +426,7 @@
{
"action": "Send to Customer",
"allow_self_approval": 1,
"allowed": "Administrator",
"condition": null,
"next_state": "Sent to Customer",
"parent": "Mockup Workflow",
"parentfield": "transitions",
"parenttype": "Workflow",
"state": "Draft",
"workflow_builder_id": null
},
{
"action": "Send to Customer",
"allow_self_approval": 1,
"allowed": "Administrator",
"allowed": "Lead User",
"condition": null,
"next_state": "Sent to Customer",
"parent": "Mockup Workflow",
Expand Down Expand Up @@ -493,13 +481,13 @@
"doctype": "Workflow",
"document_type": "Feasibility Check",
"is_active": 1,
"modified": "2025-01-07 17:27:54.678117",
"modified": "2025-01-13 15:52:41.566527",
"name": "Feasibility workflow",
"override_status": 0,
"send_email_alert": 0,
"states": [
{
"allow_edit": "Administrator",
"allow_edit": "Lead User",
"avoid_status_override": 0,
"doc_status": "0",
"is_optional_state": 0,
Expand All @@ -514,7 +502,7 @@
"workflow_builder_id": null
},
{
"allow_edit": "Administrator",
"allow_edit": "Lead User",
"avoid_status_override": 0,
"doc_status": "0",
"is_optional_state": 0,
Expand All @@ -523,7 +511,7 @@
"parent": "Feasibility workflow",
"parentfield": "states",
"parenttype": "Workflow",
"state": "Sent to Customer",
"state": "Sent to Feasibility Analyst",
"update_field": null,
"update_value": null,
"workflow_builder_id": null
Expand Down Expand Up @@ -561,11 +549,11 @@
],
"transitions": [
{
"action": "Send to Customer",
"action": "Send to Feasibility Analyst",
"allow_self_approval": 1,
"allowed": "Administrator",
"allowed": "Lead User",
"condition": null,
"next_state": "Sent to Customer",
"next_state": "Sent to Feasibility Analyst",
"parent": "Feasibility workflow",
"parentfield": "transitions",
"parenttype": "Workflow",
Expand All @@ -581,7 +569,7 @@
"parent": "Feasibility workflow",
"parentfield": "transitions",
"parenttype": "Workflow",
"state": "Sent to Customer",
"state": "Sent to Feasibility Analyst",
"workflow_builder_id": null
},
{
Expand All @@ -593,7 +581,7 @@
"parent": "Feasibility workflow",
"parentfield": "transitions",
"parenttype": "Workflow",
"state": "Sent to Customer",
"state": "Sent to Feasibility Analyst",
"workflow_builder_id": null
},
{
Expand All @@ -605,7 +593,7 @@
"parent": "Feasibility workflow",
"parentfield": "transitions",
"parenttype": "Workflow",
"state": "Sent to Customer",
"state": "Sent to Feasibility Analyst",
"workflow_builder_id": null
}
],
Expand Down
7 changes: 7 additions & 0 deletions versa_system/fixtures/workflow_action_master.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,12 @@
"modified": "2024-12-13 15:29:39.126493",
"name": "Send to Customer",
"workflow_action_name": "Send to Customer"
},
{
"docstatus": 0,
"doctype": "Workflow Action Master",
"modified": "2025-01-13 15:41:16.165025",
"name": "Send to Feasibility Analyst",
"workflow_action_name": "Send to Feasibility Analyst"
}
]
9 changes: 9 additions & 0 deletions versa_system/fixtures/workflow_state.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,15 @@
"style": "",
"workflow_state_name": "Review Request"
},
{
"docstatus": 0,
"doctype": "Workflow State",
"icon": "",
"modified": "2025-01-13 15:39:50.784815",
"name": "Sent to Feasibility Analyst",
"style": "",
"workflow_state_name": "Sent to Feasibility Analyst"
},
{
"docstatus": 0,
"doctype": "Workflow State",
Expand Down
4 changes: 2 additions & 2 deletions versa_system/hooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,13 +248,13 @@
{
"dt": "Workflow State",
"filters": [
["name", "in", ["Draft","Review Request","Approved","Rejected","Sent to Customer"]]
["name", "in", ["Draft","Review Request","Approved","Rejected","Sent to Customer","Sent to Feasibility Analyst"]]
]
},
{
"dt": "Workflow Action Master",
"filters": [
["name", "in", ["Approve", "Reject", "Review Request","Send to Customer"]]
["name", "in", ["Approve", "Reject", "Review Request","Send to Customer","Send to Feasibility Analyst"]]
]
}
]
6 changes: 3 additions & 3 deletions versa_system/versa_system/doctype/feasibility_check/feasibility_check.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"actions": [],
"allow_rename": 1,
"autoname": "Feas.#####",
"autoname": "format:FC-{YYYY}-{#####}",
"creation": "2024-12-07 16:11:46.809290",
"doctype": "DocType",
"engine": "InnoDB",
Expand Down Expand Up @@ -55,11 +55,11 @@
"index_web_pages_for_search": 1,
"is_submittable": 1,
"links": [],
"modified": "2024-12-13 13:27:59.468820",
"modified": "2025-01-13 15:06:39.116582",
"modified_by": "Administrator",
"module": "Versa System",
"name": "Feasibility Check",
"naming_rule": "Expression (old style)",
"naming_rule": "Expression",
"owner": "Administrator",
"permissions": [
{
Expand Down