This repository was archived by the owner on Jun 20, 2023. It is now read-only.
Feature/domain agnosticism#1
Open
odgrim wants to merge 4 commits intoegnyte:masterfrom
odgrim:feature/domain_agnosticism
Open
Feature/domain agnosticism#1odgrim wants to merge 4 commits intoegnyte:masterfrom odgrim:feature/domain_agnosticism
odgrim wants to merge 4 commits intoegnyte:masterfrom
odgrim:feature/domain_agnosticism
Conversation
There was a problem hiding this comment.
This url should not be https:// . It should be configurable so that we can test against local dev box who is simple http://
Author
There was a problem hiding this comment.
Let's get these in another pull request! They're extremely valid and should be addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some domains are vanity urls and hardcoding the EGNYTE_DOMAIN as a global precludes them from working. I added a small parse to see if we pass in a full url or just a subdomain meant to be prepended to .egnyte.com.