This repository was archived by the owner on Jan 7, 2020. It is now read-only.
Replacing deprecated/broken "compress-buffer" with builtin zlib#2
Open
schwarmco wants to merge 1 commit intoegorFiNE:masterfrom
schwarmco:replacing_compress-buffer
Open
Replacing deprecated/broken "compress-buffer" with builtin zlib#2schwarmco wants to merge 1 commit intoegorFiNE:masterfrom schwarmco:replacing_compress-buffer
schwarmco wants to merge 1 commit intoegorFiNE:masterfrom
schwarmco:replacing_compress-buffer
Conversation
Owner
|
The sad truth is that the project is long deprecated. It was written in times of node 0.2 and too many things changed since then. Internally we have rewritten this software from scratch a couple of years ago but never got our hands to actually release the whole thing. And yet still even the updated version is ancient by modern node/JS standards. So I guess this is abandonware. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
i don't know if you're still maintaining this project, but as i tried to
npm install stock, it failed because of the compress-buffer-package.Looking it up showed me, that this is also a package you maintain - and as you mentioned in issue #13 it's deprecated and should be replaced by builtin-functions...
so, here you go... (for the tests to pass, you need to rebuild the test-data)
please let me know, if you're still maintaining this package because i have another thing or two to contribute, if you want so...
kind regards
Joachim