feat: Spring Boot 3.5 + Java 25 LTS + Virtual Threads migration#1241
Draft
ChakshuGautam wants to merge 12 commits intoegovernments:masterfrom
Draft
feat: Spring Boot 3.5 + Java 25 LTS + Virtual Threads migration#1241ChakshuGautam wants to merge 12 commits intoegovernments:masterfrom
ChakshuGautam wants to merge 12 commits intoegovernments:masterfrom
Conversation
Add build/maven-jdk21/ as a new Dockerfile variant alongside the existing build/maven/ (JDK 17). Services on Spring Boot 3.x are switched to the new Dockerfile; legacy services (Spring Boot 1.5/2.x) remain on JDK 17 unchanged. Why: - JDK 17 has a cgroup v2 CPU detection bug (JDK-8281181) on kernel 6.8+ — the JVM sees all host CPUs instead of the container's CPU limit, spawning 50-60 threads instead of ~15. - JDK 21 fixes this and auto-sizes heap/GC/threads from cgroup limits, eliminating the need for manual JVM tuning flags. - JDK 21 runs Java 17 bytecode natively (no recompilation needed). New files: - build/maven-jdk21/Dockerfile: eclipse-temurin:21-jre-alpine runtime with CDS (Class Data Sharing) pre-dump for faster startup - build/maven-jdk21/start.sh: no default -Xms/-Xmx, CDS loading Updated: build-config.yml - 26 Spring Boot 3.x services → build/maven-jdk21/Dockerfile - 32 legacy/other services → unchanged (build/maven/Dockerfile) - 1 service (egov-user) → unchanged (build/maven-java8/Dockerfile) Validated on docker-compose local-setup (jar-swap approach): - 12 services rebased, all healthy - k6 load test: 100% success (104 transactions, 0 failures) - Memory: ~24% RSS reduction, ~42% thread count reduction Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
egov-user is on Spring Boot 1.5 / JDK 8 and cannot be easily migrated to Spring Boot 3.2. This new build variant compiles with JDK 8 but runs on JDK 21, getting cgroup v2 fixes and memory improvements without a framework migration. The hybrid approach: - Build stage: same JDK 8 Maven image (amazoncorretto-8) - Patch stage: injects JAXB API + runtime jars (removed from JDK 11+) - Runtime stage: eclipse-temurin:21-jre-alpine with CDS + --add-opens Measured results (8 vCPU / 16 GB VM): - Memory at idle: 461 MiB → 184 MiB (60% reduction) - Memory under 300 VU load: OOM-killed → 286 MiB (56% of limit) - Threads: 50+ → 34 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Phase 0 of Spring Boot 3.5 migration: - services-common: SB 3.2.2→3.5.12, javax→jakarta, JUnit 5 - tracer: SB 3.2.2→3.5.12, OTel 1.46/2.12, add WebClient.Builder bean + logging filter - mdms-client: SB 3.2.2→3.5.12, RestTemplate→WebClient - enc-client: SB 3.2.2→3.5.12, RestTemplate→WebClient, JUnit 5 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Phase 1 of Spring Boot 3.5 migration. All services already on 3.2.2 upgraded to 3.5.12 with spring.threads.virtual.enabled=true: Tier 1 (clean): egov-mdms-service, egov-otp, egov-localization, egov-persister, service-request, mdms-v2 Tier 2 (RestTemplate): egov-location, egov-url-shortening, boundary-service, audit-service, user-otp, egov-user-event Tier 3/4 (complex): egov-filestore, egov-idgen, egov-enc-service, egov-accesscontrol, egov-notification-mail, egov-notification-sms, egov-indexer, egov-workflow-v2, egov-pg-service, gateway, internal-gateway-scg Additional fixes: - Lombok 1.18.22→1.18.36 (JDK 21 compatibility) - javax.validation→jakarta.validation in egov-workflow-v2 (16 files) - javax.mail→jakarta.mail in egov-notification-mail - Spring Cloud 2023.0.0→2025.0.0 for gateway services - commons-lang→commons-lang3 import fixes Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Phase 2 of Spring Boot 3.5 migration - highest risk services: egov-user: - Spring Boot 1.5.22→3.5.12, Java 8→17, virtual threads - Complete OAuth2 security rewrite: removed spring-security-oauth2 (deprecated), replaced with custom token management using CustomRedisTokenStore + OAuthController - SecurityConfig: WebSecurityConfigurerAdapter→SecurityFilterChain - Redis: Jedis→Lettuce (Spring Boot 3.x default) - javax.servlet→jakarta.servlet - Flyway properties migrated to spring.flyway.* namespace - OAuth2Exception→AuthenticationServiceException tenant: - Spring Boot 1.5.22→3.5.12, Java 8→17, virtual threads - WebMvcConfigurerAdapter→WebMvcConfigurer - Flyway properties migrated, flyway-database-postgresql added Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…threads Migrate 9 services that were on Spring Boot 1.5.22/2.2.13/2.3.8: - egov-common-masters (1.5.22→3.5.12): javax→jakarta, StringUtils fix - egov-data-uploader (1.5.22→3.5.12): javax→jakarta, flyway migration - egov-document-uploader (2.2.13→3.5.12): javax→jakarta - egov-searcher (2.2.13→3.5.12): javax→jakarta - report (2.2.13→3.5.12): javax→jakarta - chatbot (2.2.13→3.5.12): javax→jakarta, commons-io dependency - national-dashboard-ingest (2.2.13→3.5.12): remove dead server.contextPath - national-dashboard-kafka-pipeline (2.2.13→3.5.12): remove dead server.contextPath - internal-gateway (2.3.8→3.5.12): Zuul→Spring Cloud Gateway MVC All services compile with mvn clean compile -DskipTests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The Spring Cloud Gateway (gateway/) on SB 3.5.12 already replaces the deprecated Zuul service (zuul/, SB 2.2.13). All core Zuul filters have equivalent implementations in the gateway service: - Auth, RBAC, rate limiting, correlation ID, request enrichment - Reactive (Netty) architecture vs Zuul's blocking Tomcat model - Built-in OTEL tracing support Fixed a malformed property line in gateway application.properties where two properties were concatenated on one line. The zuul/ service is now deprecated and should not be deployed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Complete rewrite of the API Gateway from Netflix Zuul (deprecated) to
Spring Cloud Gateway (reactive, Netty-based).
Key changes:
- Spring Boot 2.2.13 → 3.5.12, Java 8 → 17
- Netflix Zuul → Spring Cloud Gateway 4.3.3 (reactive)
- ZuulFilter → GlobalFilter with Ordered interface
- RequestContext → ServerWebExchange attributes
- RestTemplate → WebClient (non-blocking)
- javax.servlet → reactive ServerHttpRequest/ServerHttpResponse
- Custom request body caching for multi-read in filter chain
- zuul.routes.* → RouteLocator bean reading same routes.properties
- Zuul rate limiting → Spring Cloud Gateway RequestRateLimiter (Redis)
Filter chain preserved (same order and behavior):
-1000 CachedBodyGlobalFilter (caches request body)
-999 RequestStartTimeFilter
0 CorrelationIdFilter
1 AuthPreCheckFilter (auth token extraction)
2 RbacPreCheckFilter
3 AuthFilter (user service call via WebClient)
4 RbacFilter (access control call via WebClient)
5 RequestEnrichmentFilter (body enrichment)
post: ResponseEnhancementFilter, CustomAsyncFilter, PostEventLogFilter
66 files changed, 1568 insertions, 3841 deletions.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fixes 9 services that failed `mvn package` on a clean CI machine: JUnit 4 → JUnit 5 test migration (7 services): - egov-user: Full test migration - Matchers→ArgumentMatchers, @test(expected=...)→assertThrows(), extends→implements ArgumentMatcher, removed obsolete CustomAuthenticationKeyGenerator reference - tenant: JUnit 4→5 annotations, mockito.runners→mockito.junit.jupiter - egov-data-uploader: JUnit 4→5 test annotations - egov-searcher, report: JUnit 4→5 test annotations - national-dashboard-ingest/kafka-pipeline: Added junit-vintage-engine Dependency version fixes (2 services): - egov-common-masters: mdms-client 0.0.2-SNAPSHOT→2.9.0-SNAPSHOT - internal-gateway-scg: tracer 2.9.0-SNAPSHOT→2.9.1-SNAPSHOT All 35 services + 4 libraries now pass `mvn package` on a clean JDK 21 + Maven 3.8.7 machine (egov-ci). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
JUnit 4 → 5 migration for all 18 test files: - @RunWith(SpringRunner/MockitoJUnitRunner) → @ExtendWith(SpringExtension/MockitoExtension) - @before → @beforeeach, @test → @test (jupiter) - org.junit.Assert → org.junit.jupiter.api.Assertions - Added commons-io 2.18.0 as test-scoped dependency (needed by test helpers) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- report: enc-client 2.0.3-SNAPSHOT → 2.9.0-SNAPSHOT - egov-searcher: enc-client 2.0.4-SNAPSHOT → 2.9.0-SNAPSHOT - egov-notification-sms: enc-client 2.9.1 → 2.9.0-SNAPSHOT - user-otp: tracer 2.9.0-SNAPSHOT → 2.9.1-SNAPSHOT - zuul: tracer 2.9.0-SNAPSHOT → 2.9.1-SNAPSHOT - mdms-v2: services-common 2.0.0-SNAPSHOT → 2.9.0-SNAPSHOT Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Remove hardcoded log4j2.version=2.17.1 from 26 pom.xml files (lets Spring Boot 3.5 manage the version, fixes IncompatibleClassChangeError) - Remove @Autowired from @bean methods in 16 config files (Spring 3.5 auto-injects @bean method parameters) - Convert void @bean to @PostConstruct in MDMSService.java - Update java.version from 17 to 25 across all 40 services (Java 25 LTS) - Update Dockerfiles: build with Eclipse Temurin 25, runtime on JRE 25 Alpine Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ChakshuGautam
requested review from
GhanshyamRawat-eGov and
talele08
as code owners
|
Important Review skippedToo many files! This PR contains 300 files, which is 150 over the limit of 150. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (300)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate all DIGIT core services from Spring Boot 1.5/2.x + Java 8 to Spring Boot 3.5.12 + Java 25 LTS with virtual threads enabled. This is a complete platform modernization covering 35+ services, 4 shared libraries, and the API gateway layer.
spring.threads.virtual.enabled=trueChanges by Category
1. Spring Boot 3.5.12 Migration (Services)
All core services upgraded from Spring Boot 1.5.x/2.x to 3.5.12:
egov-user,tenant,egov-persister,egov-indexer,egov-localizationegov-workflow-v2,egov-mdms-service,mdms-v2,egov-filestoreegov-idgen,egov-otp,user-otp,egov-notification-smsegov-notification-mail,egov-url-shortening,egov-user-eventegov-enc-service,egov-pg-service,egov-accesscontrolegov-location,egov-searcher,egov-data-uploaderegov-document-uploader,egov-common-masters,reportaudit-service,boundary-service,service-request,chatbotnational-dashboard-ingest,national-dashboard-kafka-pipeline2. Shared Libraries
tracer→ Spring Boot 3.5.12, Jakarta EE 9+, WebClient-based RESTservices-common→ Spring Boot 3.5.12 + Jakartamdms-client→ Spring Boot 3.5.12 + Jakartaenc-client→ Spring Boot 3.5.12 + Jakarta3. Gateway: Zuul → Spring Cloud Gateway
4. Key Migrations Applied Across All Services
javax.*→jakarta.*(Servlet, Persistence, Validation, XML Bind)RestTemplate→WebClient(non-blocking HTTP)WebSecurityConfigurerAdapter→SecurityFilterChainbeanspring-cloud-starter-configreplaced withspring-cloud-starter-bootstraporg.postgresql.Driver(unchanged),com.mysql.cj.jdbc.Driverspring.redis.*→spring.data.redis.*5. Java 25 LTS Target
pom.xml:<java.version>25</java.version>maven:3.9.9-eclipse-temurin-25-alpineeclipse-temurin:25-jre-alpine6. CI Validation Fixes (43 files)
Fixes discovered during full-stack CI validation:
<log4j2.version>2.17.1</log4j2.version>from 26 pom.xml files (fixesIncompatibleClassChangeError— let Spring Boot BOM manage Log4j2)@Autowiredfrom@Beanmethods in 16 config files (Spring 6.2+ auto-injects@Beanmethod parameters)@Beanto@PostConstructinMDMSService.javaValidation Results
Core Health & Smoke Tests (13/13 pass)
All services start successfully and respond to health checks with the migrated stack running on Docker Compose.
PGR Lifecycle Integration Test (16/16 pass)
Full complaint lifecycle validated end-to-end:
Runtime Configuration Notes
Services require these flags (set in Docker Compose / K8s manifests):
egov-useradditionally needs-Dmanagement.endpoints.web.base-path=/if healthcheck hits/user/healthinstead of/actuator/health.Build Infrastructure
Three Dockerfile variants in
build/:build/maven/Dockerfilebuild/maven-jdk21/Dockerfilebuild/maven-java8-jdk21/DockerfileAll include CDS (Class Data Sharing) pre-dump for faster container startup.
Test plan
🤖 Generated with Claude Code