Skip to content

treewide: use workflow.source_path()#296

Merged
veprbl merged 10 commits into
masterfrom
pr/source_path
May 23, 2026
Merged

treewide: use workflow.source_path()#296
veprbl merged 10 commits into
masterfrom
pr/source_path

Conversation

@veprbl
Copy link
Copy Markdown
Member

@veprbl veprbl commented May 13, 2026

This is required for running workflows with a scheduler plugin.

Copilot AI review requested due to automatic review settings May 13, 2026 01:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Converts hard-coded "benchmarks/<dir>/..." script input paths in Snakefiles to use Snakemake's workflow.source_path(...) helper, which resolves paths relative to the Snakefile. This is required to support running these workflows via a Snakemake scheduler plugin (where the working directory may differ from the repo root).

Changes:

  • Replace literal "benchmarks/<name>/..." script paths with workflow.source_path("...") across many benchmark Snakefiles.
  • Compiled .so artifacts and non-source runtime inputs are intentionally left as plain paths.
  • No rule logic, outputs, or shell commands changed.

Reviewed changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.

Show a summary per file
File Description
benchmarks/zdc_sigma/Snakefile Use workflow.source_path for gen and plot scripts.
benchmarks/zdc_pi0/Snakefile Same conversion for generation and plotting scripts.
benchmarks/zdc_photon/Snakefile Same conversion for generation and plotting scripts.
benchmarks/zdc_neutron/Snakefile Convert hepmc-gen and analysis script inputs.
benchmarks/zdc_lyso/Snakefile Convert gen and analysis script inputs.
benchmarks/zdc_lambda/Snakefile Convert gen and plotting script inputs.
benchmarks/tracking_performances/Snakefile Convert several .C script inputs to source_path.
benchmarks/tracking_performances_dis/Snakefile Convert .cxx script inputs; compiled .so paths left as-is.
benchmarks/nhcal_sampling_fraction/Snakefile Convert analysis script input.
benchmarks/nhcal_pion_rejection/Snakefile Convert analysis script input.
benchmarks/nhcal_dimuon_photoproduction/Snakefile Convert analysis script input.
benchmarks/nhcal_basic_distribution/Snakefile Convert two analysis script inputs.
benchmarks/nhcal_acceptance/Snakefile Convert analysis script input.
benchmarks/lfhcal/Snakefile Convert performance and comparison script inputs.
benchmarks/insert_tau/Snakefile Convert gen and plotting script inputs.
benchmarks/insert_neutron/Snakefile Convert gen and plotting script inputs.
benchmarks/insert_muon/Snakefile Convert gen and plotting script inputs.
benchmarks/femc_pi0/Snakefile Convert gen and plotting script inputs.
benchmarks/femc_photon/Snakefile Convert gen and plotting script inputs.
benchmarks/femc_electron/Snakefile Convert gen and plotting script inputs.
benchmarks/far_forward_dvcs/Snakefile Convert analysis cxx script input (compiled .so left as-is).
benchmarks/ecal_gaps/Snakefile Convert plotting script input.
benchmarks/calo_pid/Snakefile Convert plotting script input.
benchmarks/backwards_ecal/Snakefile Convert plotting script input.
benchmarks/backgrounds/Snakefile Convert plotting script input.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@veprbl veprbl enabled auto-merge (squash) May 13, 2026 01:41
@veprbl veprbl disabled auto-merge May 13, 2026 21:25
Copy link
Copy Markdown
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@veprbl veprbl enabled auto-merge (squash) May 21, 2026 19:31
@veprbl veprbl merged commit a7771d4 into master May 23, 2026
3 checks passed
@veprbl veprbl deleted the pr/source_path branch May 23, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants