benchmarks/rich: fix compatibility with edm4hep-1.0, podio-1.7

[wdconinc]

Problem

The RICH benchmark failed when upgrading to edm4hep-1.0, podio-1.7, algorithms-1.3.0, k4fwcore-1.5 (CI job #7877888):

terminate called after throwing an instance of 'std::runtime_error'
what(): Cannot retrieve collection ReconstructedChargedParticleAssociations of type edm4eic::MCRecoParticleAssociationCollection

Root Cause

Three interacting issues:

1. Stale collection name: run_benchmark.rb requested ReconstructedChargedParticleAssociationsWithDRICHPID in output_collections, but this collection no longer exists in EICrecon. Since JANA2's podio output writes only the explicitly listed collections, ReconstructedChargedParticleAssociations was absent from the rec file.

2. podio 1.7 API change: Frame::get<C>(name) now throws std::runtime_error when a collection is absent or has a type mismatch (podio 1.6 and earlier returned a static empty collection instead). The old isValid() guard was therefore never reached — the exception propagated uncaught.

3. Deprecated API: isValid() on collections is deprecated in the edm4eic-generated headers in favour of hasID().

Note: before the podio 1.7 upgrade the stale collection name caused the ReconstructedParticle analysis to silently produce empty results rather than crash, since Frame::get<C>() returned an invalid collection without throwing.

Fix

• run_benchmark.rb: Replace non-existent ReconstructedChargedParticleAssociationsWithDRICHPID with ReconstructedChargedParticleAssociations (the correct current EICrecon output collection name).
• src/benchmark.cc: Wrap frame.get<C>() in a try-catch; return an empty collection on error so callers can continue gracefully. The try-catch is harmless for older podio versions where get<C>() does not throw.
• src/ReconstructedParticleAnalysis.cc: Replace deprecated isValid() with hasID().

[Copilot]

Pull request overview

Fixes the RICH benchmark’s breakage after upgrading to newer EDM/podio stacks by updating the requested output collection name and making collection retrieval resilient to podio’s newer exception-throwing behavior.

Changes:

• Update run_benchmark.rb to request ReconstructedChargedParticleAssociations instead of the removed ...WithDRICHPID collection.
• Wrap podio::Frame::get<C>() in a try/catch for podio ≥ 0.99 to avoid aborting when collections are missing/mismatched.
• Replace deprecated collection validity check with hasID() in ReconstructedParticleAnalysis.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
benchmarks/rich/src/ReconstructedParticleAnalysis.cc	Switches association-collection validity check from deprecated isValid() to hasID().
benchmarks/rich/src/benchmark.cc	Makes collection retrieval robust to podio’s throwing Frame::get behavior via try/catch and returns an empty collection on failure.
benchmarks/rich/run_benchmark.rb	Updates output_collections to the current EICrecon association collection name so it’s written to the rec file.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.