Skip to content

Add CI workflow to build against eic-shell#34

Merged
wdconinc merged 3 commits into
masterfrom
copilot/add-ci-workflow
Dec 3, 2025
Merged

Add CI workflow to build against eic-shell#34
wdconinc merged 3 commits into
masterfrom
copilot/add-ci-workflow

Conversation

Copilot AI commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

Repository lacked GitHub Actions CI for testing PRs. Added a minimal build workflow using the eic-shell environment, following the pattern from EICrecon.

Changes

  • Added .github/workflows/linux-eic-shell.yml with:
    • Triggers on push to main, PRs, and manual dispatch
    • Concurrency control to cancel redundant runs
    • Build step using CVMFS + eic-shell (eic_xl:nightly)
- uses: cvmfs-contrib/github-action-cvmfs@v5
- name: Build
  uses: eic/run-cvmfs-osg-eic-shell@main
  with:
    platform-release: "${{ env.platform }}:${{ env.release }}"
    run: |
      cmake -B build -S . -DCMAKE_INSTALL_PREFIX=install
      cmake --build build -j $(getconf _NPROCESSORS_ONLN) --target install
Original prompt

This section details on the original issue you should resolve

<issue_title>Add CI workflow to this repository</issue_title>
<issue_description>Is your feature request related to a problem? Please describe.
This repository has no github actions workflow to test functionality of pull requests.

Describe the solution you'd like
Implement a CI workflow similar to https://github.com/eic/EICrecon/tree/main/.github/workflows/linux-eic-shell.yml (but much more limited). It should only include a simple build within the eic-shell environment.
</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Copilot AI changed the title [WIP] Add CI workflow for pull request testing Add CI workflow to build against eic-shell Dec 3, 2025
Copilot AI requested a review from wdconinc December 3, 2025 16:21
@wdconinc wdconinc marked this pull request as ready for review December 3, 2025 16:21
Copilot AI review requested due to automatic review settings December 3, 2025 16:21
Comment thread .github/workflows/linux-eic-shell.yml Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a GitHub Actions CI workflow to enable automated build testing for pull requests and pushes to main. The workflow uses the eic-shell environment via CVMFS, following the pattern established in the EICrecon repository. This addresses the repository's lack of automated CI testing.

Key changes:

  • Added workflow that triggers on push to main, pull requests, and manual dispatch
  • Configured build job using eic_xl:nightly environment with standard CMake build commands
  • Implemented concurrency control to cancel redundant workflow runs

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wdconinc wdconinc enabled auto-merge (squash) December 3, 2025 16:26
@kkauder

kkauder commented Dec 3, 2025

Copy link
Copy Markdown
Collaborator

I'm not very familiar with CI. Lgtm, but how could I test?

@wdconinc

wdconinc commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

I'm not very familiar with CI. Lgtm, but how could I test?

Look at https://github.com/eic/eic-smear/actions/runs/19900950398/job/57044424341?pr=34 :-)

@wdconinc

wdconinc commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

I'm not very familiar with CI. Lgtm, but how could I test?

Look at https://github.com/eic/eic-smear/actions/runs/19900950398/job/57044424341?pr=34 :-)

If you want, suggest a test command to run to make sure it actually does what it is supposed to do.

Or implement CTest unit tests :-D :-D

@wdconinc wdconinc merged commit 2648dca into master Dec 3, 2025
1 check passed
@wdconinc wdconinc deleted the copilot/add-ci-workflow branch December 3, 2025 17:04
@kkauder

kkauder commented Dec 3, 2025

Copy link
Copy Markdown
Collaborator

Test command(s) would be easy, but for historical reasons, test data lives in https://github.com/eic/eicsmeardetectors, which presumably isn't even installed anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CI workflow to this repository

4 participants