Suppress error message when not finding libsmeardetectors#36
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #35 by suppressing error messages when the libeicsmeardetectors library is not found. Since this library is no longer installed by default, the warning message was unnecessarily alarming users. The fix temporarily raises the error ignore level to suppress the warning during library loading.
- Suppresses error messages by temporarily setting
gErrorIgnoreLeveltokFatalwhen attempting to loadlibeicsmeardetectors - Conditionally retrieves the library path only if the library was successfully loaded
- Prevents confusing error output when the optional library is not present
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Closed
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
See the issue. libeicsmeardetectors is no longer installed by default, so suppress the warning when we're not finding it.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No
Does this PR change default behavior?
No