Conversation
for more information, see https://pre-commit.ci
Member
Author
|
I understand this workaround and approve the change. Please approve the PR, @alexander-kiselev. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts pfRICH’s IRT2 geometry “dummy” G4LogicalVolume* identifiers to avoid the reported 0x(1)1-style collision/issue when pfRICH and dRICH are used together, and adds a ready-made configuration enabling tracking + dRICH + pfRICH in one YAML.
Changes:
- Update pfRICH IRT2 helper calls to use a distinct range of placeholder
G4LogicalVolume*values (0x10–0x13) instead of the previous low values (0x0–0x3). - Attach the pfRICH photon detector to the same placeholder volume ID used for the pfRICH gas container volume.
- Add
configurations/tracking_and_drich_and_pfrich.ymlto enable tracking + dRICH + pfRICH features together.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/PFRICH_geo.cpp | Changes IRT2 “placeholder logical volume” identifiers used for pfRICH radiators/container and photon detector registration. |
| configurations/tracking_and_drich_and_pfrich.yml | New configuration combining tracking with both dRICH and pfRICH PID features. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
176
to
179
|
|
||
| auto radiator = | ||
| geometry->SetContainerVolume(cdet, "GasVolume", 0, (G4LogicalVolume*)(0x0), 0, boundary); | ||
| geometry->SetContainerVolume(cdet, "GasVolume", 0, (G4LogicalVolume*)(0x10), 0, boundary); | ||
| radiator->SetAlternativeMaterialName(vesselGasName.c_str()); |
| @@ -445,7 +445,7 @@ static Ref_t createDetector(Detector& description, xml_h e, SensitiveDetector se | |||
| auto pd = new IRT2::CherenkovPhotonDetector(0, 0); | |||
|
|
|||
| // FIXME: '0' stands for the unknown (and irrelevant) G4LogicalVolume; | |||
Contributor
Capybara summary for PR 1109
|
Contributor
|
This PR needs a better description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submitting on behalf of @alexander-kiselev.