FIX/ Grouped Jobs/ New grouped keyed jobs dont crash ExJob#10
Open
macrocreation wants to merge 1 commit into
Open
FIX/ Grouped Jobs/ New grouped keyed jobs dont crash ExJob#10macrocreation wants to merge 1 commit into
macrocreation wants to merge 1 commit into
Conversation
ExJob has has the ability to serialize execution of a group of jobs mapped to a particular key. The ages map is used to select which is the next key to work with. This map is not correctly cleaned up when there are no more pending jobs for a particular key The result: when a job with a completely new key is added after jobs with another key have been executed, the older key selected, even though there are no pending jobs associated with that key, causing a crash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExJob has has the ability to serialize execution of a group of jobs mapped to a particular key.
The ages map is used to select which is the next key to work with. This map is not correctly cleaned up when there are no more pending jobs for a particular key
The result: when a job with a completely new key is added after jobs with another key have been executed, the older key selected, even though there are no pending jobs associated with that key, causing a crash.