Update the branch with changes from upstream 2.8 master.#14
Open
angavrilov wants to merge 4 commits intoeigen-value:rigify_0.6_betafrom
Open
Update the branch with changes from upstream 2.8 master.#14angavrilov wants to merge 4 commits intoeigen-value:rigify_0.6_betafrom
angavrilov wants to merge 4 commits intoeigen-value:rigify_0.6_betafrom
Conversation
Registering and unregistering the class causes 2.8 to complain about non-annotation properties, and this avoids the problem. Plus, legacy and non-legacy shouldn't interact. The 'make annotation' spam also happens on addon enable toggle, so apply the legacy toggle fix globally.
RigifyParameterValidator doesn't like the difference.
In 2.8 custom property creation becomes more complex, with the need to set a default value for correct NLA blending and an overridable flag for static overrides. The most logical way to do that is to refactor rigs to use the new make_property utility, and implement the new features there. This backports all those changes minus the actual new features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes changes that have already been committed to the upstream 2.8 addons repository.