Skip to content

Update to QUDT v2.1.4#2

Open
gnmerritt wants to merge 18 commits intoeigendude:mainfrom
gnmerritt:main
Open

Update to QUDT v2.1.4#2
gnmerritt wants to merge 18 commits intoeigendude:mainfrom
gnmerritt:main

Conversation

@gnmerritt
Copy link
Copy Markdown
Contributor

Hi - thanks for the great QUDT bindings!

We're using them with a newer version of the QUDT ontology, and so here's a PR with our changes. There are currently a number of disabled unit tests for units that are defined outside QUDT (micromolar, etc) that I unfortunately don't have the hours to put against fixing up. That said, I think this branch is a good starting point for the ontology version upgrade so I wanted to at least start a discussion about potentially merging it.

Note: this PR also updates frozendict to make it safe for Python 3.9+ -an old import pattern is deprecated and being discontinued so I believe the package as-is will be broken.

@eigendude
Copy link
Copy Markdown
Owner

eigendude commented May 28, 2021

@gnmerritt Sorry I missed this last year. I'm surprised someone found the library! If you built anything from it I'd love to see.

@eigendude eigendude changed the base branch from master to main September 22, 2021 23:49
@eigendude
Copy link
Copy Markdown
Owner

eigendude commented Sep 23, 2021

@gnmerritt I added CI, which includes isort and black, so there will be some git conflicts. These can be dealt with by attempting a rebase, and when the conflict occurs, check out the original commit in this branch via git checkout <hash> -- quidt test, then run black and isort, then add, commit and continue the rebase. The effect is exactly this code here but applied on the stylized codebase.

"skos": "http://www.w3.org/2004/02/skos/core#",
"xsd": "http://www.w3.org/2001/XMLSchema#"
"xsd": "http://www.w3.org/2001/XMLSchema#",
"kind": "http://qudt.org/vocab/quantitykind/"
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small request, can you keep lists in alphabetical order?

@eigendude
Copy link
Copy Markdown
Owner

I noticed a list that could be alphabetized. But aside from that everything here looks good. @gnmerritt are you willing to rebase?

@gnmerritt
Copy link
Copy Markdown
Contributor Author

Yeah I'll be able to get to it after the holidays

@eigendude
Copy link
Copy Markdown
Owner

@gnmerritt I fixed the rebase conflicts on my end so there's nothing blocking this PR. What's its current state?

@gnmerritt
Copy link
Copy Markdown
Contributor Author

ahh sorry, didn't realize I had the PR up from my main branch. you're welcome to merge my changes if you want, but I don't have any work time in the near future to help with that effort unfortunately

@eigendude
Copy link
Copy Markdown
Owner

OK, no worries! Do you want to close this to avoid the noise here? Feel free to re-open if life brings you bountiful time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants