chore: trim #334 comments and dead test scaffolding#397
Open
Conversation
- renderPage.ts: 6 explanatory lines → 3. - edge-cases.spec.ts: drop unused `hasSegoe`, simplify the page-font assertion to a single string check. - changeset: shorter summary. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up cleanup to #335 — pure diff polish, no behavior change.
Changes
packages/core/src/layout-painter/renderPage.ts— 6-line explanatory comment compressed to 3 lines, keeping the Page Margin Misalignment Bug #334 reference and the reason measurement and rendering must agree.e2e/tests/edge-cases.spec.ts—page font fallback matches measurement fallback (#334)simplified: drops the unusedhasSegoefield and the multi-paragraph in-test essay, keeps thetoContain('carlito')assertion that actually fails without fix(core): align page font fallback with measurement chain (fixes #334) #335 and passes with it..changeset/issue-334-cleanup.md— short patch entry.Test plan
bun run typecheckpasses.edge-cases.spec.ts— the simplified test still asserts the same condition.🤖 Generated with Claude Code