fix: pass local MCP config to backend instead of empty object #1194
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Wendong-Fan @Pakchoioioi Please review this PR. |
Contributor
Author
|
@Wendong-Fan could you merge this pr? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #959
Description
Fixes models not seeing or using installed MCPs (e.g. Firecrawl). The frontend was loading local MCP config from Electron but always sending an empty
installed_mcpin the chat request, so the backend never received the real MCP list. The request body now sends the actual local MCP config when starting a chat so the backend can connect to MCP servers and expose their tools to the model.What is the purpose of this pull request?