feat(asb-controller): withdraw bitcoin#891
Merged
binarybaron merged 5 commits intomasterfrom Mar 5, 2026
Merged
Conversation
Author
|
@Einliterflasche Please review. |
Author
|
bugbot run |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
High Risk
Adds new JSON-RPC methods that can broadcast Bitcoin spend transactions and force wallet resync; mistakes or exposure of the RPC endpoint could directly impact funds.
Overview
Adds writable wallet operations over ASB JSON-RPC. Introduces
withdraw_btc(amount in satoshis,nullto sweep) andrefresh_bitcoin_walletmethods toswap-controller-api, implements them in the ASB RPC server, and exposes matchingasb-controllercommands (parsing human-friendlybitcoin::Amountand converting to sats on the wire).Refactors BTC withdrawal logic into a shared
bitcoin_wallet::withdrawhelper used by both the ASB/CLI withdrawal path and the new controller RPC.Tor reliability workaround: sets
ARTI_FS_DISABLE_PERMISSION_CHECKS=1during Tor client creation in bothswapandlibp2p-rendezvous-nodeto avoid failures on managed systems, and documents the new commands inCHANGELOG.md.Written by Cursor Bugbot for commit 8637481. This will update automatically on new commits. Configure here.