Skip to content

feat(asb-controller): withdraw bitcoin#891

Merged
binarybaron merged 5 commits intomasterfrom
feat/withdraw-btc-rpc-arti-fix
Mar 5, 2026
Merged

feat(asb-controller): withdraw bitcoin#891
binarybaron merged 5 commits intomasterfrom
feat/withdraw-btc-rpc-arti-fix

Conversation

@binarybaron
Copy link

@binarybaron binarybaron commented Mar 5, 2026

  • fix(arti): Workaround for when the machine is running in a managed work-environment
  • feat(asb, asb-controller): add refresh_bitcoin_wallet and withdraw_btc commands

Note

High Risk
Adds new JSON-RPC methods that can broadcast Bitcoin spend transactions and force wallet resync; mistakes or exposure of the RPC endpoint could directly impact funds.

Overview
Adds writable wallet operations over ASB JSON-RPC. Introduces withdraw_btc (amount in satoshis, null to sweep) and refresh_bitcoin_wallet methods to swap-controller-api, implements them in the ASB RPC server, and exposes matching asb-controller commands (parsing human-friendly bitcoin::Amount and converting to sats on the wire).

Refactors BTC withdrawal logic into a shared bitcoin_wallet::withdraw helper used by both the ASB/CLI withdrawal path and the new controller RPC.

Tor reliability workaround: sets ARTI_FS_DISABLE_PERMISSION_CHECKS=1 during Tor client creation in both swap and libp2p-rendezvous-node to avoid failures on managed systems, and documents the new commands in CHANGELOG.md.

Written by Cursor Bugbot for commit 8637481. This will update automatically on new commits. Configure here.

@binarybaron
Copy link
Author

@Einliterflasche Please review.

@binarybaron
Copy link
Author

bugbot run

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

@binarybaron binarybaron merged commit 698415b into master Mar 5, 2026
45 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant