Add CI tests, Windows installer cleanup, and streaming click-track rendering#6
Conversation
ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Free Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds platform-aware analysis caching and sample-rate-aware cache keys, streams click-track rendering in blocks, makes PyInstaller builds platform-specific with Windows GUI/install metadata improvements, updates CI to run tests before builds, and revises docs for platform-specific build and log locations. ChangesPlatform-specific installers and audio infrastructure
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant CI as GitHub Actions
participant TestJob as jobs.test
participant BuildJob as jobs.build
participant PyInstaller as PyInstaller
participant EmbeddedInstaller as Windows Installer GUI
participant Resolve as DaVinciResolve
participant FS as FileSystem
Dev->>CI: push PR
CI->>TestJob: run unit tests (python)
TestJob->>CI: tests pass/fail
CI->>BuildJob: needs: test -> run build
BuildJob->>PyInstaller: build_cli_binary(platform="windows")
PyInstaller->>FS: write openbeat.exe / bundle
BuildJob->>EmbeddedInstaller: embed installer script
EmbeddedInstaller->>Resolve: check running (tasklist)
EmbeddedInstaller->>FS: install_openbeat() -> return install_result paths
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Poem
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 140ad5881d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ROOT / "openbeat" / "cli.py", | ||
| python_bin=python_bin, | ||
| onefile=platform != "windows", | ||
| windowed=platform == "windows", |
There was a problem hiding this comment.
Remove windowed mode from Windows CLI runtime build
Building the bundled openbeat runtime with --windowed makes it a noconsole app on Windows, where PyInstaller documents that sys.stdout/sys.stderr are unavailable; this conflicts with the shipped CLI implementation (for example click-track prints JSON in openbeat/cli.py) and can raise runtime errors instead of producing output. In the installer flow, Resolve invokes this binary for click-track generation, so Windows installs can fail during normal feature use even though packaging succeeds.
Useful? React with 👍 / 👎.
…ux-improvements # Conflicts: # docs/guide.md
Summary
Testing
python3 -m compileall openbeat scripts tests.OpenBeatCommon.lua.uv run --no-project --python 3.11 --with-editable . python -m unittest discover -s tests -v.main; CI is rerunning under the artifact-upload-safe workflow.