Fix Hermes imported history and native tool activity rendering#4
Conversation
|
Warning Review limit reached
Next review available in: 1 minute Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (30)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 73bbd72d34
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const childSessionId = HermesBridgeSessionId.make(`t3-${existingThreadId}`); | ||
| const refreshRequestId = HermesBridgeRequestId.make( | ||
| `conversation-refresh:${source.sessionId}:${existingThreadId}:${yield* dependencies.randomUuid}`, | ||
| ); | ||
| const fork = yield* client | ||
| .forkSession({ |
There was a problem hiding this comment.
Refresh the Hermes child session before reusing it
When an existing external import is opened after the source Hermes session has received more messages, this refresh path reuses t3-${existingThreadId}. The t3agent adapter's /v1/sessions/fork handler only calls db.replace_messages inside if not child_exists, so the response refreshes the T3 projection but the bound Hermes child session that future prompts run against still contains the old copied messages. Please update the existing matching child session's stored messages during refresh, or create a new child session, before opening it.
Useful? React with 👍 / 👎.
…hat-formatting # Conflicts: # apps/server/src/provider/hermes/HermesConversationLifecycle.ts
Summary
Testing