Fix SIC logging to use cat() pattern consistent with NAICS and MACT#276
Merged
ejanalysis merged 4 commits intomact-naics-sic-defaultsfrom Mar 5, 2026
Merged
Fix SIC logging to use cat() pattern consistent with NAICS and MACT#276ejanalysis merged 4 commits intomact-naics-sic-defaultsfrom
ejanalysis merged 4 commits intomact-naics-sic-defaultsfrom
Conversation
Co-authored-by: ejanalysis <8205979+ejanalysis@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update defaults for mact, naics, sic in ejamapp() based on feedback
Fix SIC logging to use cat() pattern consistent with NAICS and MACT
Feb 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a minor inconsistency in the Shiny server logging for SIC code selection. The print(inputsic) call was replaced with cat(paste0(inputsic, collapse = ", "), "\n") to match the identical pattern already used for NAICS and MACT logging, producing uniform console output format across all three input types.
Changes:
- Replaced
print(inputsic)withcat(paste0(inputsic, collapse = ", "), "\n")indata_up_sicreactive to align logging style with NAICS (L767–768) and MACT (L1265–1266).
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
print(inputsic)was used for SIC code logging while NAICS and MACT usedcat(), causing inconsistent console output format.Change
Replaced
print(inputsic)with the samecat()pattern used elsewhere:💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.