Skip to content

Fix SIC logging to use cat() pattern consistent with NAICS and MACT#276

Merged
ejanalysis merged 4 commits intomact-naics-sic-defaultsfrom
copilot/sub-pr-273
Mar 5, 2026
Merged

Fix SIC logging to use cat() pattern consistent with NAICS and MACT#276
ejanalysis merged 4 commits intomact-naics-sic-defaultsfrom
copilot/sub-pr-273

Conversation

Copy link
Contributor

Copilot AI commented Feb 26, 2026

print(inputsic) was used for SIC code logging while NAICS and MACT used cat(), causing inconsistent console output format.

Change

Replaced print(inputsic) with the same cat() pattern used elsewhere:

# Before
cat("selected SIC:  ")
print(inputsic)

# After — matches NAICS (L767-768) and MACT (L1265-1266) pattern
cat("selected SIC:  ")
cat(paste0(inputsic, collapse = ", "), "\n")

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: ejanalysis <8205979+ejanalysis@users.noreply.github.com>
Copilot AI changed the title [WIP] Update defaults for mact, naics, sic in ejamapp() based on feedback Fix SIC logging to use cat() pattern consistent with NAICS and MACT Feb 26, 2026
@ejanalysis ejanalysis marked this pull request as ready for review March 5, 2026 02:39
@ejanalysis ejanalysis requested a review from Copilot March 5, 2026 02:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a minor inconsistency in the Shiny server logging for SIC code selection. The print(inputsic) call was replaced with cat(paste0(inputsic, collapse = ", "), "\n") to match the identical pattern already used for NAICS and MACT logging, producing uniform console output format across all three input types.

Changes:

  • Replaced print(inputsic) with cat(paste0(inputsic, collapse = ", "), "\n") in data_up_sic reactive to align logging style with NAICS (L767–768) and MACT (L1265–1266).

You can also share your feedback on Copilot code review. Take the survey.

@ejanalysis ejanalysis merged commit 8686555 into mact-naics-sic-defaults Mar 5, 2026
4 checks passed
@ejanalysis ejanalysis deleted the copilot/sub-pr-273 branch March 5, 2026 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants