fix: apply CRC wire format to reconnectable writer, re-send path, and test#540
Closed
claude-claude[bot] wants to merge 1 commit intonv2-tx-barrierfrom
Closed
fix: apply CRC wire format to reconnectable writer, re-send path, and test#540claude-claude[bot] wants to merge 1 commit intonv2-tx-barrierfrom
claude-claude[bot] wants to merge 1 commit intonv2-tx-barrierfrom
Conversation
… test The CRC header was added to the non-reconnectable writer_loop and server request_reader, but was missing from: 1. writer_loop_reconnectable - sends [length][body] instead of [CRC][length][body] 2. do_reconnect re-send path - same issue when re-sending pending requests 3. test_request_reader_exits_on_deserialize_failure - tests old wire format 4. send_request_no_reply - missing .with_checksum() on WireRequest Without these fixes, any system using reconnectable multiplexer (snapshot/clone path) would have immediate frame desync with the server. Also updates wire.rs module docs to document the new request wire format. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Owner
|
Will address in #539 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-Fix for PR #539
Issues Fixed
writer_loop_reconnectablemissing CRC header — Sends[length][body]instead of[CRC][length][body], causing frame desync with the server on snapshot/clone reconnection pathdo_reconnectre-send missing CRC header — Same frame desync when re-sending pending requests after reconnectiontest_request_reader_exits_on_deserialize_failuremissing CRC header — Test sends old wire format, causing it to test "message too large" instead of "deserialization failure"send_request_no_replymissing.with_checksum()— Fire-and-forget requests (forget/batch_forget) don't have payload-level checksum unlike regular requestswire.rsstill show old formatChanges
fuse-pipe/src/client/multiplexer.rs: Add CRC computation and header write towriter_loop_reconnectableanddo_reconnectre-send path; add.with_checksum()tosend_request_no_replyfuse-pipe/src/server/pipelined.rs: Add CRC header totest_request_reader_exits_on_deserialize_failurefuse-pipe/src/protocol/wire.rs: Update module-level documentation to show CRC-prefixed request formatGenerated by Claude | Review Run