Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
==========================================
+ Coverage 99.32% 99.47% +0.14%
==========================================
Files 20 20
Lines 1785 1516 -269
==========================================
- Hits 1773 1508 -265
+ Misses 9 5 -4
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
482fba3 to
a4bd490
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Between some cloud resources requiring multiple steps to remove and those steps becoming asynchronous we need a way to properly handle it. Previously all steps had to be synchronous within the Remove method, but due to the asynchronous nature, this was causing the need for more resources to implement HandleWait, but that meant doing actual removes in HandleWait method, which isn’t a natural place to think a remove should take place.
Known Limitation
If you implement a phased method wrong it can get stuck in a wait state forever, need to ensure that all phased functions properly return properly and check the async status of the cloud resource properly.