[Rolling] Implement pose graph node marginalization#3
Closed
hidmic wants to merge 4 commits into
Closed
Conversation
hidmic
force-pushed
the
feature/chow_liu_marginalization
branch
from
December 30, 2021 15:41
4242eb4 to
8e3880f
Compare
hidmic
marked this pull request as ready for review
December 30, 2021 15:41
Collaborator
Author
|
@kmilo7204 alright, code's complete here. Need to do some testing now, and watch out for SteveMacenski#398. |
hidmic
changed the title
|
@hidmic After a couple of revisions, I could say that code looks great! Just a minor comment: Are you going to add documents (Papers) in code comments or that will not be relevant at all? |
Collaborator
Author
@kmilo7204 Indeed I am. See 31aea91. |
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
hidmic
force-pushed
the
feature/chow_liu_marginalization
branch
from
January 2, 2022 16:49
e32399c to
31aea91
Compare
hidmic
changed the title
Collaborator
Author
|
See #5. Had to go back to ROS 1 to find a good enough simulation for our testing purposes. |
Collaborator
Author
|
I'll close this for now. Once SteveMacenski#468 goes in, we can port it to Rolling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Future work that may be required in bullet points