Fixes to enable x86_64 build#22
Open
nicolov wants to merge 5 commits into
Open
Conversation
nicolov
force-pushed
the
fixes_for_64_build
branch
from
bccbde4 to
ee59db1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few fixes to enable building on x86_64. Besides the typos, there was a problem in the multicall binary code (
src/vpnserver/vpnserver.c). On uClibc,argv[]should not be modified by the program, but the non-GNU version ofbasenamedoes indeed change its argument. For some reason, this was only showing up as a segfault on 64bit builds. I've found a reference to this problem here.