Fix absolute path detection with empty path components.#28
Open
will-ca wants to merge 1 commit intoelan-ev:mainfrom
Open
Fix absolute path detection with empty path components.#28will-ca wants to merge 1 commit intoelan-ev:mainfrom
will-ca wants to merge 1 commit intoelan-ev:mainfrom
Conversation
Fixes elan-ev#27. Untested. But should be simple enough. https://docs.python.org/3/library/os.path.html#os.path.abspath https://docs.python.org/3/library/os.path.html#os.path.normpath Note Python docs explicitly specify that `abspath()` usually includes a transform that is equivalent to `normpath`. Perhaps also note comment in Python docs that this "may change the meaning of a path that contains symbolic links". …Actually, why is it `.startswith()` instead of `==`, or even just `.startswith('/')`— or `path.isabs()`— anyway?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27.
Untested. But should be simple enough.
https://docs.python.org/3/library/os.path.html#os.path.abspath https://docs.python.org/3/library/os.path.html#os.path.normpath
Note Python docs explicitly specify that
abspath()usually includes a transform that is equivalent tonormpath.Perhaps also note comment in Python docs that this "may change the meaning of a path that contains symbolic links".
…Actually, why is it
.startswith()instead of==, or even just.startswith('/')— orpath.isabs()— anyway?