Skip to content

[8.19](backport #43352) Update go-libaudit and remove close/draining code#47128

Merged
fearful-symmetry merged 2 commits into8.19from
mergify/bp/8.19/pr-43352
Oct 22, 2025
Merged

[8.19](backport #43352) Update go-libaudit and remove close/draining code#47128
fearful-symmetry merged 2 commits into8.19from
mergify/bp/8.19/pr-43352

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Oct 15, 2025

Proposed commit message

This is a continuation of elastic/go-libaudit#176

This is pretty simple, all we're doing besides updating the dependency is removing the old closeAuditClient() code.

Putting this in draft while I tinker with the setPID() method in light of the changes made to go-libaudit.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

This is an automatic backport of pull request #43352 done by [Mergify](https://mergify.com).

* update go-libaudit

* notice

* add tests, refactor setPID retry

* improve docs:

* add eintr check

* clean up tests

* fix error message

* linter

(cherry picked from commit 5da0bd1)

# Conflicts:
#	NOTICE.txt
#	go.mod
#	go.sum
@mergify mergify bot requested a review from a team as a code owner October 15, 2025 16:10
@mergify mergify bot added the backport label Oct 15, 2025
@mergify mergify bot requested a review from a team as a code owner October 15, 2025 16:10
@mergify mergify bot added conflicts There is a conflict in the backported pull request backport labels Oct 15, 2025
@mergify mergify bot added the conflicts There is a conflict in the backported pull request label Oct 15, 2025
@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Oct 15, 2025

Cherry-pick of 5da0bd1 has failed:

On branch mergify/bp/8.19/pr-43352
Your branch is up to date with 'origin/8.19'.

You are currently cherry-picking commit 5da0bd169.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   auditbeat/module/auditd/audit_linux.go
	modified:   auditbeat/module/auditd/audit_linux_test.go
	modified:   auditbeat/module/auditd/mock_linux_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   NOTICE.txt
	both modified:   go.mod
	both modified:   go.sum

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 15, 2025
@github-actions github-actions bot added bug Auditbeat Team:Security-Linux Platform Linux Platform Team in Security Solution labels Oct 15, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 15, 2025
@botelastic
Copy link
Copy Markdown

botelastic bot commented Oct 15, 2025

This pull request doesn't have a Team:<team> label.

@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Oct 20, 2025

This pull request has not been merged yet. Could you please review and merge it @fearful-symmetry? 🙏

@fearful-symmetry fearful-symmetry merged commit 442bfeb into 8.19 Oct 22, 2025
203 checks passed
@fearful-symmetry fearful-symmetry deleted the mergify/bp/8.19/pr-43352 branch October 22, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auditbeat backport bug conflicts There is a conflict in the backported pull request Team:Security-Linux Platform Linux Platform Team in Security Solution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants