test: add discard output unit coverage#49596
Draft
github-actions[bot] wants to merge 1 commit intomainfrom
Draft
test: add discard output unit coverage#49596github-actions[bot] wants to merge 1 commit intomainfrom
github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
Add focused unit tests for discard output: - Verify Publish ACKs batches and reports observer counters. - Verify unknown queue config returns an error at output creation. - Verify makeDiscard forces bulk_max_size to -1. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
This pull request doesn't have a |
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds focused unit tests for
libbeat/outputs/discardto cover behavior that was previously untested:PublishACK behavior and observer accounting.makeDiscard.bulk_max_sizeoverride behavior inmakeDiscard.User scenarios
output.discardto benchmark or debug pipeline behavior, every emitted event must still be ACKed by the output path so the pipeline can progress correctly.output.discard.queuewith an invalid queue type, startup should fail with a clear error instead of silently accepting invalid configuration.output.discard, the output must disable batching (bulk_max_size = -1) so publisher behavior is consistent with this sink.Why these tests matter
bulk_max_size=-1) used by pipeline behavior.Tests run
go test ./libbeat/outputs/discard✅go test -count=5 ./libbeat/outputs/discard✅ (stability/repeatability check)Removed or merged tests
What is this? | From workflow: Test Improver
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.