Skip to content

[Rule Tuning] Entra ID OAuth User Impersonation to Microsoft Graph#5864

Open
terrancedejesus wants to merge 4 commits intomainfrom
terrancedejesus/issue5863
Open

[Rule Tuning] Entra ID OAuth User Impersonation to Microsoft Graph#5864
terrancedejesus wants to merge 4 commits intomainfrom
terrancedejesus/issue5863

Conversation

@terrancedejesus
Copy link
Contributor

@terrancedejesus terrancedejesus commented Mar 23, 2026

Fixes #5863

Pull Request

Issue link(s):

Summary - What I changed

Tunes rule to add multiple ASN requirements to reduce false positives. Please see the related issue for more details.

How To Test

Due to the query being aggregation-based, unable to test ESQL query in global alert telem; instead the query still matches on the emulation done awhile back.
Screenshot 2026-03-23 at 10 22 50 AM

Checklist

  • Added a label for the type of pr: bug, enhancement, schema, maintenance, Rule: New, Rule: Deprecation, Rule: Tuning, Hunt: New, or Hunt: Tuning so guidelines can be generated
  • Added the meta:rapid-merge label if planning to merge within 24 hours
  • Secret and sensitive material has been managed correctly
  • Automated testing was updated or added to match the most common scenarios
  • Documentation and comments were added for features that require explanation

Contributor checklist

@github-actions
Copy link
Contributor

Rule: Tuning - Guidelines

These guidelines serve as a reminder set of considerations when tuning an existing rule.

Documentation and Context

  • Detailed description of the suggested changes.
  • Provide example JSON data or screenshots.
  • Provide evidence of reducing benign events mistakenly identified as threats (False Positives).
  • Provide evidence of enhancing detection of true threats that were previously missed (False Negatives).
  • Provide evidence of optimizing resource consumption and execution time of detection rules (Performance).
  • Provide evidence of specific environment factors influencing customized rule tuning (Contextual Tuning).
  • Provide evidence of improvements made by modifying sensitivity by changing alert triggering thresholds (Threshold Adjustments).
  • Provide evidence of refining rules to better detect deviations from typical behavior (Behavioral Tuning).
  • Provide evidence of improvements of adjusting rules based on time-based patterns (Temporal Tuning).
  • Provide reasoning of adjusting priority or severity levels of alerts (Severity Tuning).
  • Provide evidence of improving quality integrity of our data used by detection rules (Data Quality).
  • Ensure the tuning includes necessary updates to the release documentation and versioning.

Rule Metadata Checks

  • updated_date matches the date of tuning PR merged.
  • min_stack_version should support the widest stack versions.
  • name and description should be descriptive and not include typos.
  • query should be inclusive, not overly exclusive. Review to ensure the original intent of the rule is maintained.

Testing and Validation

  • Validate that the tuned rule's performance is satisfactory and does not negatively impact the stack.
  • Ensure that the tuned rule has a low false positive rate.

@terrancedejesus terrancedejesus requested a review from a team March 23, 2026 14:24
@terrancedejesus terrancedejesus marked this pull request as ready for review March 23, 2026 14:24
Comment on lines -132 to -133
"9ea1ad79-fdb6-4f9a-8bc3-2b70f96e34c7", // Bing
"d7b530a4-7680-4c23-a8bf-c52c121d2e87", // Microsoft Edge Enterprise New Tab Page [Community Contributed]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason these can be removed from the exception, is due to the other noise reduction from this PR right?

Copy link
Contributor

@eric-forte-elastic eric-forte-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once date is fixed, then I think this looks good 👍

@terrancedejesus terrancedejesus requested a review from a team March 24, 2026 16:33
Co-authored-by: Eric Forte <119343520+eric-forte-elastic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Rule Tuning] Entra ID OAuth User Impersonation to Microsoft Graph

2 participants