Skip to content

[release] move gh release creation after git tag #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SylvainJuge merged 1 commit into from
Apr 27, 2026
+19 −18
Merged

[release] move gh release creation after git tag #408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 19 additions & 18 deletions .github/workflows/release-step-3.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,27 @@ jobs:
artifact-id: 'ecs-logging-core'
version: ${{ inputs.version }}

post-release:
name: "Bump versions and create PR"
needs:
- await-maven-central-artifact
uses: ./.github/workflows/pre-post-release.yml
permissions:
contents: write
if: inputs.dry_run == false
with:
ref: ${{ inputs.ref }}
version: ${{ inputs.version }}
phase: 'post'
pr_title: "[release] release-step-4 ${{ inputs.version }}"
pr_body: "Step 4 of the release process for version ${{ inputs.version }}: review & merge"
secrets: inherit

create-github-release:
name: "Create GitHub Release"
needs:
- await-maven-central-artifact
# git tag is created by 'post-release', and we require it to exist to be able to create a github release.
- post-release
runs-on: ubuntu-latest
Comment on lines 149 to 154
Copy link

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create-github-release now depends on the entire post-release job. In pre-post-release.yml, the post phase creates/pushes the git tag early, but later steps (branch creation, version bump, PR creation) can still fail. If that happens, the run will end with post-release failed, create-github-release will never run, and re-running may be blocked because the reusable workflow’s validate-tag job will now fail due to the already-existing tag. Consider decoupling tag creation into a dedicated job (or making the post-release workflow idempotent / moving tag creation to the end) and have create-github-release depend on that tag-creation success rather than the full post-release PR workflow.

Copilot uses AI. Check for mistakes.
if: inputs.dry_run == false
permissions:
Expand All @@ -149,20 +166,4 @@ jobs:
run: |
gh release create ${{ env.RELEASE_VERSION_TAG }} \
--title="Release ${{ env.RELEASE_VERSION }}" \
--generate-notes

post-release:
name: "Bump versions and create PR"
needs:
- await-maven-central-artifact
uses: ./.github/workflows/pre-post-release.yml
permissions:
contents: write
if: inputs.dry_run == false
with:
ref: ${{ inputs.ref }}
version: ${{ inputs.version }}
phase: 'post'
pr_title: "[release] release-step-4 ${{ inputs.version }}"
pr_body: "Step 4 of the release process for version ${{ inputs.version }}: review & merge"
secrets: inherit
--generate-notes
Loading