Keep the parsed pattern property keys#3
Merged
jsoriano merged 2 commits intoelastic:package-specfrom Mar 12, 2026
Merged
Conversation
mrodm
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pattern property keys are evaluated for every property whose
name doesn't exactly match with a named property key.
Current implementation is compiling the regular expression of
each pattern once when loading the schema, and another one for
each property.
For reference, these compilations take around 15% of the total
execution time of a Package Spec validation, as found while
investigating elastic/package-spec#1110.
This change stores the compilation done when parsing the schema,
so it can be reused on validations later.
To be merged after #2.