[aws] add ignore_failure: true for uri_parts processor in s3access data stream#17915
Open
kaiyan-sheng wants to merge 2 commits intomainfrom
Open
[aws] add ignore_failure: true for uri_parts processor in s3access data stream#17915kaiyan-sheng wants to merge 2 commits intomainfrom
kaiyan-sheng wants to merge 2 commits intomainfrom
Conversation
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
S3 access log can include request paths that
uri_partsprocessor cannot parse, such as/[[...optional]]. This change setsignore_failure: trueon theuri_partsstep so parsing continues even thoughuri_partsfailed.With this change,
aws.s3access.request_uriand related fields remain available, and ECSurl.*is only populated when the path is parseable.Checklist
changelog.ymlfile.