Skip to content

Input packages: dataset var and dotted index patterns#17924

Open
marc-gr wants to merge 4 commits intoelastic:mainfrom
marc-gr:input-template-fixes
Open

Input packages: dataset var and dotted index patterns#17924
marc-gr wants to merge 4 commits intoelastic:mainfrom
marc-gr:input-template-fixes

Conversation

@marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Mar 20, 2026

Summary

Addresses #15295 for the Custom macOS Unified Logs (unifiedlogs) input package by making the dataset configurable and visible in Fleet, and by ensuring the agent input config receives data_stream.dataset (same idea as other input packages, e.g. winlog).

Changes (unifiedlogs only)

  • manifest.yml: add data_stream.dataset (default unifiedlogs.generic, required, user-visible).
  • agent/input/unifiedlogs.yml.hbs: emit data_stream.dataset under data_stream: so Fleet-generated policies pass the dataset through to the agent.
  • changelog.yml: version bump + entry (see PR).
  • Policy tests (_dev/test/policy/): default dataset vs custom dataset (elastic_agent.test) to lock in the generated Fleet/agent policy shape.

Related

@andrewkroh andrewkroh added Integration:unifiedlogs Custom macOS Unified Logs Integration:winlog Custom Windows Event Logs Integration:filestream Custom Logs (Filestream) Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] Team:Security-Windows Platform Security Windows Platform team [elastic/sec-windows-platform] labels Mar 20, 2026
@elasticmachine
Copy link

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@elasticmachine
Copy link

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think only the change in the configuration template is needed. Data streams and input patterns should be managed by Fleet.

@marc-gr marc-gr force-pushed the input-template-fixes branch from 89804c1 to 6c92105 Compare March 20, 2026 13:51
@marc-gr
Copy link
Contributor Author

marc-gr commented Mar 20, 2026

Yes I realized it was missing after the fact. This feels like prone to error though, would be interesting to enforce it somehow

@andrewkroh andrewkroh removed Integration:winlog Custom Windows Event Logs Integration:filestream Custom Logs (Filestream) labels Mar 20, 2026
@marc-gr marc-gr requested a review from jsoriano March 23, 2026 10:22
- Policy tests for default (unifiedlogs.generic) and custom (elastic_agent.test) datasets
- Expose data_stream.dataset in manifest for Fleet (aligned with filestream/cel)
- Bump package to 0.4.2
@elasticmachine
Copy link

💚 Build Succeeded

History

@marc-gr marc-gr enabled auto-merge (squash) March 23, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:unifiedlogs Custom macOS Unified Logs Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] Team:Security-Windows Platform Security Windows Platform team [elastic/sec-windows-platform]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants